New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite local modifications with updates #1463

Closed
arantius opened this Issue Nov 3, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@arantius
Copy link
Collaborator

arantius commented Nov 3, 2011

Please discuss. We already know the file-modified time and the last update check time. We should be able to use these values to determine that the script has changed on disk since the last update (/install ?) and choose not to overwrite it with remote updates.

Is this important? Is this foolproof? Is this a good idea?

@johan

This comment has been minimized.

Copy link
Collaborator

johan commented Nov 3, 2011

My thoughts are "yes", "workable" and "yes".

File-modified times are probably not idiot-proof, but should at least cater the 90%+ case, and likely even 99%. (I know that access-time updates is sometimes disable on file systems for disk or battery performance but haven't heard of similar things for modified-time.)

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Nov 4, 2011

Having slept on it, we need to track one more bit of information, I think. If install time (currently not tracked) === modified time, updates are always safe to install. If modified time > install time, then updates should not be installed. Last update check time doesn't really factor into things.

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Feb 6, 2012

New issue for tracking install time logged for v.Next, using that info (for updates, also pushed) pushed to v.Nextnext.

@arantius arantius closed this in ca9621f Feb 10, 2012

@arantius arantius reopened this Feb 11, 2012

@arantius arantius closed this in fb16949 Feb 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment