Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Set update url correctly when installing previous versions on Userscripts.org #1474

Closed
sizzlemctwizzle opened this Issue Nov 23, 2011 · 0 comments

Comments

Projects
None yet
2 participants
Contributor

sizzlemctwizzle commented Nov 23, 2011

Currently when we install from a Userscripts.org url like this: http://userscripts.org/scripts/source/24464.user.js
We set the updateURL to this: http://userscripts.org/scripts/source/24464.meta.js

But Userscripts.org also lets you install previous versions for urls like this: http://userscripts.org/scripts/version/24464/401392.user.js
Which we then incorrectly turn into this: http://userscripts.org/scripts/version/24464/401392.meta.js

@arantius arantius closed this in 62fed40 Dec 8, 2011

arantius added a commit to arantius/greasemonkey that referenced this issue Dec 9, 2011

Martii pushed a commit to Martii/greasemonkey that referenced this issue Dec 9, 2011

Properly set scriptid, "meta.js" and variants on host names for US.o …
…updateURLs

Refs #1474

Sample Current Version URI: https://userscripts.org/scripts/source/68219.user.js
Sample Versioned URI: https://userscripts.org/scripts/version/68219/408798.user.js
Sample Incorrectly set FQDN but currently valid URI: https://www.userscripts.org/scripts/source/68219.user.js
Sample Greasefired Incorrectly set FQDN but currently valid and user.js URI: https://greasefire.userscripts.org/scripts/source/68219.user.js
Sample Greasefired Incorrectly set FQDN but currently valid URI: https://greasefire.userscripts.org/scripts/source/68219.meta.js
etc.

All paths should yield one of these two URIs depending on SSL status for userscripts.org only:
http://userscripts.org/scripts/source/68219.meta.js
https://userscripts.org/scripts/source/68219.meta.js

Anything else is untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment