New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstall goes to suffixed directory #1515

Closed
arantius opened this Issue Feb 10, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@arantius
Copy link
Collaborator

arantius commented Feb 10, 2012

Install a script named foo; it will go inside a directory named "foo" inside gm_scripts. Reinstall it. It will go to "foo-1". After install, the old copy is uninstalled. A second reinstall will thus go to "foo", and repeat. Ideally re-installing the same script would keep the same install location.

@mjh563

This comment has been minimized.

Copy link

mjh563 commented Feb 15, 2012

A related problem: reinstall a script, then go to the Add-ons Manager, right-click the script name and select Edit. The script can't be loaded, because it's still looking for it in the previous directory.

@mjh563

This comment has been minimized.

Copy link

mjh563 commented Feb 15, 2012

It works OK after Firefox is restarted.

arantius added a commit to arantius/greasemonkey that referenced this issue Feb 24, 2012

Do GM_config.install() _before_ putting a RemoteScript's files in place.
This cleans the old script's files out first, so the names on disk do not collide.

Fixes: greasemonkey#1515, greasemonkey#1520

@arantius arantius closed this Feb 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment