Skip to content
This repository

Implement RemoteScript incremental download #1523

Closed
arantius opened this Issue February 28, 2012 · 4 comments

2 participants

arantius gsky916
arantius
Collaborator

See: #1458, #1511

When I was writing RemoteScript, my intent was that it would check the contents of the file as it was being downloaded, and pop up the install dialog as soon as the metadata was known (so that the download progress of big/slow script files themselves could be reported). I didn't do that quite right. Thus #1511 was reported because installs can be confusingly silent for too much time. Make this work as intended.

arantius arantius referenced this issue from a commit April 10, 2012
Commit has since been removed from the repository and is no longer available.
arantius
Collaborator

This is a work in progress, at https://github.com/arantius/greasemonkey/compare/incremental-download

It drops nsIWebBrowserPersist in favor of handling the nsIChannel itself, so that it can grab the data as downloaded, and thus find the metadata ASAP. This fulfils my original intent when I fixed #1458, so the script install window (with progress bar) comes up much sooner (as soon as the metadata is available).

@gsky916, can you try out this build and let me know if this does enough to solve #1511 for you?
https://github.com/downloads/arantius/greasemonkey/greasemonkey-2012.04.10.beta.xpi

gsky916

Thank you, but still no toast notification? Without it i always doubt if the script installed successfully then i need to check in the addon manage page.(bad habit mabe.......)

Yes, the install window comes up much sooner but still did not satisfied the need of confirmation, i mean, how to confirm the script install successfully in a install window?

arantius
Collaborator

Yes, the install window comes up much sooner but still did not satisfied the need of confirmation, i mean, how to confirm the script install successfully in a install window?

If you pressed "install" it installed OK. A notification wouldn't provide anything more; if it didn't install OK, it means that there was some sort of unhandled error situation (the bug could be as likely to let the notification show as not).

arantius arantius closed this in 0d742eb April 11, 2012
gsky916

So...If i pressed "install" then it must installed successfully?
Sigh...I was just used to that toast notification. I don't know if you have plan to make it back, that's all my ask for.
Actually it was more like a personal habit issue, if you don't want to deal with that, just forget it.

Thank you all the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.