New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not launch editor (164333.user.js) #1732

Closed
shyangs opened this Issue Apr 9, 2013 · 8 comments

Comments

Projects
None yet
5 participants
@shyangs
Copy link

shyangs commented Apr 9, 2013

  1. Install userscripts#164333
  2. Press "Edit this User Script"
  3. An error occurred

Win7x64 Greasemonkey 1.8

@LouCypher

This comment has been minimized.

Copy link

LouCypher commented Apr 9, 2013

I was able to edit this script with selected editor by right clicking on the script entry on Add-ons Manager and select 'Edit'.

The issue is, if I use Options on this script and click the Edit button, GM tried to open Scratchpad to edit this script and failed. GM then used Scratchpad to edit any script, replacing my selected editor.

The issue never happened if I change the @namespace block from

http://wiki.moztw.org/%E4%BD%BF%E7%94%A8%E8%80%85:Shyangs#tieba_adv_search

to

http://wiki.moztw.org/User:Shyangs#tieba_adv_search

@shyangs, can you confirm this?

@shyangs

This comment has been minimized.

Copy link

shyangs commented Apr 9, 2013

Yes, it is just like what you said.

@janekptacijarabaci

This comment has been minimized.

Copy link
Contributor

janekptacijarabaci commented Apr 9, 2013

It can be modified, for example:
https://github.com/greasemonkey/greasemonkey/blob/master/modules/parseScript.js#L63

-   case 'namespace': 
    case 'version': 
      script['_' + header] = value; 
+     break; 
+   case 'namespace': 
+     script['_' + header] = decodeURI(value);
@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Apr 9, 2013

There is definitely no requirement that namespaces are URLs, only that they are unique strings. So that doesn't immediately feel like the right thing to do.

@janekptacijarabaci

This comment has been minimized.

Copy link
Contributor

janekptacijarabaci commented Apr 9, 2013

Yes, it was just an example.

However:
http://wiki.greasespot.net/Metadata_Block#.40namespace
"a URL is often used"

The minimum should be, for example:
"Here's a list of common illegal characters: %..."

Probably not very relevant but better fixed than unfixed.

@arantius arantius closed this in 2aedc31 Apr 25, 2013

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Apr 25, 2013

btoa/atob might not be good enough; see comment on commit; reopening

@arantius arantius reopened this Apr 25, 2013

@MayhemYDG

This comment has been minimized.

Copy link

MayhemYDG commented Apr 25, 2013

@arantius
But the solution is in the link I gave you.

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented May 3, 2013

@arantius arantius closed this May 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment