New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified date shown in about:addons is wrong #1744

Closed
hurda opened this Issue May 22, 2013 · 13 comments

Comments

Projects
None yet
3 participants
@hurda
Copy link

hurda commented May 22, 2013

Setup: Fx 21, GM 1.9

When installing or updating a script, the modified date shown in about:addons is wrong, stating "Thursday 1st, 1970".

After closing and restarting the browser, the proper date is shown.
Another workaround is editing the script, saving and closing the editor.

With GM 1.8, the modified-date is shown correctly after updating/installing.

The modified-date can be shown with custom stylesheets, i.e.:

@-moz-document url(chrome://mozapps/content/extensions/extensions.xul), url(about:addons) {
    @media all and (min-width: 900px) {
        #list-view:not([type="userstyle"]):not([type="userscript"]) #addon-list .content-inner-container {
            display: inline-table !important;
            width: 100% !important;
        }
        #list-view:not([type="userstyle"]):not([type="userscript"]) #addon-list .basicinfo-container {
            min-width: 300px !important;
            width: 50% !important;
        }
        #list-view:not([type="userstyle"]):not([type="userscript"]) #addon-list .advancedinfo-container {
            width: 50% !important;
        }
        #list-view:not([type="userstyle"]):not([type="userscript"]) #addon-list .addon-view:not([value$="@personas.mozilla.org"]) .date-updated {display: -moz-box !important;}
        #list-view:not([type="userstyle"]):not([type="userscript"]) #addon-list .addon-view[active="true"]:not([selected]) .date-updated {opacity: .5 !important;}
    }
}
@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented May 23, 2013

Are you saying that this only happens when you apply this custom stylesheet?

@hurda

This comment has been minimized.

Copy link

hurda commented May 23, 2013

The modified-date isn't shown by default, you can only show it with custom styles or addons like Cleanest Addon Manager. I took the stylesheet from that addon.

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented May 23, 2013

It works in the detail view every way I try it. That's the supported display.

@arantius arantius closed this May 23, 2013

@hurda

This comment has been minimized.

Copy link

hurda commented May 23, 2013

What's the detail-view?

Here's a screenshot before updating, and after updating and installing a userscript with GM 1.9.
4jpvkco

With 1.8, this doesn't happen.

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented May 23, 2013

Double click.

@hurda

This comment has been minimized.

Copy link

hurda commented May 23, 2013

OK, after updating:
yy7iofk

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented May 23, 2013

And what exactly did you do? Install/update/change the script? Any script that's already installed?

@arantius arantius reopened this May 23, 2013

@hurda

This comment has been minimized.

Copy link

hurda commented May 23, 2013

New profile, installed Greasemonkey 1.9 from AMO, restarted the browser, installed a userscript (i.e. Oct 10 version of http://userscripts.org/scripts/versions/1352 ), result: the modified-date is correct.
Then I installed the latest version of the same userscript, and the modified-date is shown as Jan 1 1970.

Couldn't reproduce the error while installing a new script with a clean profile yet, but I can reproduce it with updating/reinstalling existing scripts.

Found a way, see below.

@hurda

This comment has been minimized.

Copy link

hurda commented May 23, 2013

When about:addons is open in a tab, with the "userscript"-section selected, next to the tab with the userscript-page of the about to be newly installed script, the modified date is set to Jan 1 1970 for that one, too.

@janekptacijarabaci

This comment has been minimized.

Copy link
Contributor

janekptacijarabaci commented May 26, 2013

I suggest:

https://github.com/greasemonkey/greasemonkey/blob/master/modules/remoteScript.js#L337

-    this.script._changed('modified');
+    this.script._changed('modified', this.script.id);

This bug related to this modification:
8578882

@hurda

This comment has been minimized.

Copy link

hurda commented May 26, 2013

Yes, for me this change fixes the bug for both events (install, reinstall/update).

@arantius arantius closed this in 217da22 Jun 7, 2013

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Jun 7, 2013

This fix is now in 1.10beta1; let me know if it works for you:
https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/?page=1#version-1.10beta1

@hurda

This comment has been minimized.

Copy link

hurda commented Jun 12, 2013

Works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment