New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync causes Master Password prompt in infinite loop #1852

Closed
arantius opened this Issue Jan 3, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Jan 3, 2014

I've got a dev profile and a second test profile set up with Sync. Greasemonkey Sync support is enabled, as well as a master password, in the dev profile. When I first sync it, it asks for the (master) password once. If I install "Master Password+" it launches fine, and sync, it asks for the password once.

@bakkerthehacker

This comment has been minimized.

Copy link

bakkerthehacker commented Jan 9, 2014

Ok my steps to reproduce:

  • move ~/.mozilla to ~/.mozilla_bak
  • start firefox
  • add master password
  • add sync

at this point, starting firefox does not prompt for the password immediately

  • install greasemonkey

now starting firefox does prompt for the password immediately

  • install MP+

firefox refuses to start

My sync account is my personal account with just addons disabled.

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Jan 10, 2014

When you say "add sync" you mean .. connecting to an existing Sync account with data in it already?

I'm using: Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 "Built from http://hg.mozilla.org/releases/mozilla-release/rev/39faf812aaec". New empty testing profile.

I get a master password prompt at the "add sync" step (Tools>Set up sync>I have an account). After that restarting Firefox does indeed not (immediately) prompt for master password, but selecting "Sync now" does. Launching and waiting a while (rather than sync now) also does (where "a while" is ~a dozen seconds).

At this point adding Greasemonkey 1.13 still does not give a master password prompt on launch, but after a while (closer to a minute this time, perhaps this is semi randomized). And it just prompts once, and then works.

Adding Master Password+ 1.21.2 doesn't change anything. No prompt on launch, launch works fine. At first sync, one prompt and everything continues to work.

Something else is going on. Is this another crazy Windows only issue?

At this point as I continue to test, I realize that Greasemonkey has not been opted-in to Sync yet. Enabling and restarting produces no difference. Sync is working according to the other profile showing in about:sync-tabs, and I only get exactly the password prompts I expect. There was a bit more delay than I expected, but I also see User Scripts appearing via Sync as expected as well.

@bakkerthehacker

This comment has been minimized.

Copy link

bakkerthehacker commented Jan 16, 2014

Yes my sync account has data in it.

Something else is going on. Is this another crazy Windows only issue?

I am running linux mint 16.

Ventero added a commit to Ventero/greasemonkey that referenced this issue Feb 7, 2014

Delay importing the actual sync service.
This should prevent conflicts with the master password dialog
showing up during browser startup.

(Hopefully) fixes greasemonkey#1852.
@bakkerthehacker

This comment has been minimized.

Copy link

bakkerthehacker commented Mar 17, 2014

This is still an issue for me. I tried again today with a clean firefox profile and it is still happening. I cannot use greasemonkey while this is happening. I'm stuck on 1.12

@arantius arantius added this to the 1.16 milestone Mar 21, 2014

@arantius arantius closed this in 011ab32 Mar 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment