Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Relative @require uses wrong base URI in certain cases #1874
Steps to reproduce:
The reason for this is that a
I can see 3 options on how to fix this issue:
Solving this centrally in
So maybe we could just skip the cache completely if any argument is not
Though that seems like a lot of complexity for a function that's only used 3 times so far - so I'm definitely fine with your fix.
Ah, that makes much more sense!
It still leaves the chance of accidentally passing a complex value through memoize, which then might return an uninteded result from the cache, though. But I guess that's just something we have to look out for when adding new memoized functions.