Feature: Add "more" link on scripts in addon manager #1944

Closed
cletusc opened this Issue Jun 27, 2014 · 8 comments

Projects

None yet

5 participants

@cletusc
Contributor
cletusc commented Jun 27, 2014

I would like to see Greasemonkey support of the "more" link in the addon manager for scripts. This would bring you to an expanded "details" page that shows more info about the script.

Here is GM's addon details page marked up.
greasmonkey's details page marked up

Here is how Scriptish displays one of my scripts.
scriptish showing a userscript detail page

Ideally, the following should be on there.

  • @name:
  • @author: The "by author" should ideally be parsed in some standard format, e.g. name <email> (url) where it would link to URL if found, otherwise email if found, otherwise no link and display as-is.
  • Last updated date
  • @homepageURL: Other keys that would qualify could be @homepage.
  • @supportURL
  • @icon
  • @description

Scriptish also supports @contributionURL and @contributionAmount as seen here but I don't know how you feel about implementing them.

Consider this low priority, but still really nice to have especially with greasyfork looking to support and openuserjs supporting @supportURL and @homepageURL.

@jerone
Contributor
jerone commented Jun 27, 2014

Partly included in PR #1861

@JasonBarnabe JasonBarnabe referenced this issue in JasonBarnabe/greasyfork Aug 6, 2014
Closed

Add donation link based on @contributionURL #221

@arantius arantius added this to the Pony milestone May 29, 2015
@SamB
SamB commented May 31, 2015

+1 for @homepageURL; I just found your bug tracker solely to advocate for it.

@arantius arantius modified the milestone: 3.4, Pony May 31, 2015
@arantius arantius modified the milestone: 3.4, 3.5 Jul 24, 2015
@arantius arantius added a commit to arantius/greasemonkey that referenced this issue Sep 23, 2015
@arantius arantius Restore "more" link in AOM.
Refs #1944
2f96c6c
@arantius arantius added a commit to arantius/greasemonkey that referenced this issue Sep 23, 2015
@arantius arantius Add author and homepage script values.
For displaying in the addon manager "more" page.

Fixes #1944
25ef32a
@arantius arantius added a commit that closed this issue Sep 23, 2015
@arantius arantius Add author and homepage script values.
For displaying in the addon manager "more" page.

Fixes #1944
25ef32a
@arantius arantius closed this in 25ef32a Sep 23, 2015
@arantius
Collaborator
@arantius
Collaborator

@janekptacijarabaci Lately all your comments have been arriving over email but I can't see them on the site; you haven't changed anything recently have you?

Either way; yeah I should have checked for missing homepageURL values, I was expecting that and forgot to.

@arantius arantius reopened this Sep 24, 2015
@janekptacijarabaci
Contributor

@arantius: I'm sorry. I wanted to write in detail later...

author or homepageURL (if == null) - both.

@arantius arantius added a commit to arantius/greasemonkey that referenced this issue Sep 24, 2015
@arantius arantius Set script properties to empty string, not null.
Also only populate addon creator if author is known.

Fixes #1944
be1d16f
@arantius arantius added a commit that closed this issue Sep 24, 2015
@arantius arantius Set script properties to empty string, not null.
Also only populate addon creator if author is known.

Fixes #1944
be1d16f
@arantius arantius closed this in be1d16f Sep 24, 2015
@jerone
Contributor
jerone commented Sep 24, 2015
@arantius
Collaborator

Right, reopening. It's got to re-scan the contents of the files once to load those values into the config which fills the view.

@arantius arantius reopened this Sep 24, 2015
@arantius arantius added a commit that closed this issue Sep 30, 2015
@arantius arantius Load new metadata for existing scripts.
1) Trigger updateFromNewScript() on every script once when installing 3.5.
2) Fix updateFromNewScript() to handle new (author + homepageURL) values.

Fixes #1944
2db84e7
@arantius arantius closed this in 2db84e7 Sep 30, 2015
@jerone
Contributor
jerone commented Sep 30, 2015

Confirmed fixed in latest beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment