Address "unsafe CPOW usage" warnings #2151

Closed
arantius opened this Issue Apr 22, 2015 · 4 comments

Projects

None yet

2 participants

@arantius
Collaborator

I'm seeing them now for:

Line 266 and 270 of browser.js, in:

function GM_showPopup(aEvent) {
  function urlsOfAllFrames(contentWindow) {
    var urls = [contentWindow.location.href];
    function collect(contentWindow) {
      urls = urls.concat(urlsOfAllFrames(contentWindow));
    }
    Array.prototype.slice.call(contentWindow.frames).forEach(collect);
    return urls;
  }

The var urls = ... and the Array.prototype.slice... lines. Line 17, 23, and 28 of windowId.js.

Maybe others I haven't noticed yet.

@arantius arantius modified the milestone: 3.2, 3.3 Apr 22, 2015
@janekptacijarabaci
Contributor

Current:

cpow

@janekptacijarabaci
Contributor

I've pushed a fix to the testing branch: master...janekptacijarabaci:_testBranch_unsafe_CPOW_usage

The suggestion (for example).
It is necessary to test all options!

The warning: Thus it will not work in Firefox 24- (e.g. PaleMoon)! This works in Firefox 25+

The new solution to the issue: #2282

@arantius arantius modified the milestone: 3.3 May 29, 2015
@arantius arantius modified the milestone: 3.4, 3.3 Jun 17, 2015
@arantius arantius modified the milestone: 3.5, 3.4 Jul 31, 2015
@arantius
Collaborator

Merged by hand.

@arantius arantius closed this Sep 23, 2015
@arantius
Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment