New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e10s off] Two install dialogs (copying *.user.js files by using the drag-and-drop method) #2292

Closed
janekptacijarabaci opened this Issue Sep 26, 2015 · 9 comments

Comments

Projects
None yet
4 participants
@janekptacijarabaci
Contributor

janekptacijarabaci commented Sep 26, 2015

Ad #2179 (worksforme)

I try it all the time, but for me it takes (*copying .user.js files by using the drag-and-drop method):
Windows 7/8.1 / Ubuntu 15.04
Firefox 41.0 / Firefox Nightly 44.0a1 (2015-09-25) e10s: off
Completely empty profile (except GM)
GM 3.4.1
GM 3.5beta2

Result: Two install dialogs...

example

Please check it again. Thank you :-)

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Sep 27, 2015

Collaborator

Ah, thanks for the detail!

Collaborator

arantius commented Sep 27, 2015

Ah, thanks for the detail!

@arantius arantius added this to the 3.6 milestone Sep 27, 2015

@janekptacijarabaci

This comment has been minimized.

Show comment
Hide comment
@janekptacijarabaci

janekptacijarabaci Sep 27, 2015

Contributor

Last good: 2014-11-17
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Built from https://hg.mozilla.org/mozilla-central/rev/a52bf59965a0

First bad: 2014-11-18
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Built from https://hg.mozilla.org/mozilla-central/rev/2a292d225ec0

Pushlog
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a52bf59965a0&tochange=2a292d225ec0

=>

Last bad: 2016-02-01
Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
https://hg.mozilla.org/mozilla-central/rev/941033a51983ddec2d99aa9f868a54c0196a4075

First good: 2016-02-02
Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
https://hg.mozilla.org/mozilla-central/rev/5f9ba76eb3b1fd9377bbdb4cc2f98a7e75eabdfb

Pushlog
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=941033a51983ddec2d99aa9f868a54c0196a4075&tochange=5f9ba76eb3b1fd9377bbdb4cc2f98a7e75eabdfb

Contributor

janekptacijarabaci commented Sep 27, 2015

Last good: 2014-11-17
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Built from https://hg.mozilla.org/mozilla-central/rev/a52bf59965a0

First bad: 2014-11-18
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Built from https://hg.mozilla.org/mozilla-central/rev/2a292d225ec0

Pushlog
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a52bf59965a0&tochange=2a292d225ec0

=>

Last bad: 2016-02-01
Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
https://hg.mozilla.org/mozilla-central/rev/941033a51983ddec2d99aa9f868a54c0196a4075

First good: 2016-02-02
Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
https://hg.mozilla.org/mozilla-central/rev/5f9ba76eb3b1fd9377bbdb4cc2f98a7e75eabdfb

Pushlog
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=941033a51983ddec2d99aa9f868a54c0196a4075&tochange=5f9ba76eb3b1fd9377bbdb4cc2f98a7e75eabdfb

@rn10950

This comment has been minimized.

Show comment
Hide comment
@rn10950

rn10950 Sep 29, 2015

I can confirm that this happens with Firefox 42 on Windows XP [with e10s] and Firefox 38 ESR on Mac OS X Yosemite.

rn10950 commented Sep 29, 2015

I can confirm that this happens with Firefox 42 on Windows XP [with e10s] and Firefox 38 ESR on Mac OS X Yosemite.

@daniels1989

This comment has been minimized.

Show comment
Hide comment
@daniels1989

daniels1989 Oct 12, 2015

Possibly related. I get the same behaviour when installing a .user.js from a public Dropbox url.

Windows 7
Firefox 41.0.1
GM 3.4.1

Sample: https://dl.dropboxusercontent.com/u/936879/test.user.js

daniels1989 commented Oct 12, 2015

Possibly related. I get the same behaviour when installing a .user.js from a public Dropbox url.

Windows 7
Firefox 41.0.1
GM 3.4.1

Sample: https://dl.dropboxusercontent.com/u/936879/test.user.js

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Nov 11, 2015

Collaborator

Returning to this. Greasemonkey development at 9dac77c . Experiments include A) clicking a link in the main browser pane and B) file>open and C) drag/drop of a file onto the main browser page.

Firefox Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0, e10s on:
In all cases, I get a single installation window.

Firefox Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0, e10s off:
Clicking a link: one window. File>open: two windows. Drag/drop: two windows.

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0, e10s off (stable version has no e10s at all):
Clicking a link: one window. File>open: two windows. Drag/drop: two windows. (Same as nightly FF.)

Confirmed. Only with e10s off, which (at least now) also affects stable Firefoxen.

Collaborator

arantius commented Nov 11, 2015

Returning to this. Greasemonkey development at 9dac77c . Experiments include A) clicking a link in the main browser pane and B) file>open and C) drag/drop of a file onto the main browser page.

Firefox Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0, e10s on:
In all cases, I get a single installation window.

Firefox Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0, e10s off:
Clicking a link: one window. File>open: two windows. Drag/drop: two windows.

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0, e10s off (stable version has no e10s at all):
Clicking a link: one window. File>open: two windows. Drag/drop: two windows. (Same as nightly FF.)

Confirmed. Only with e10s off, which (at least now) also affects stable Firefoxen.

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Nov 11, 2015

Collaborator

I've looked into this a bit, but a clean solution that will work for all of file:// and http:// and for e10s on and for e10s off is currently eluding me.

Collaborator

arantius commented Nov 11, 2015

I've looked into this a bit, but a clean solution that will work for all of file:// and http:// and for e10s on and for e10s off is currently eluding me.

@arantius arantius modified the milestones: 3.7, 3.6 Nov 11, 2015

@arantius arantius closed this in f202dfa Nov 20, 2015

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Nov 20, 2015

Collaborator

3.7beta1 should fix this https://addons.mozilla.org/firefox/downloads/file/370567/greasemonkey-3.7beta1-fx.xpi?src=devhub

I'd appreciate any feedback either way.

Collaborator

arantius commented Nov 20, 2015

3.7beta1 should fix this https://addons.mozilla.org/firefox/downloads/file/370567/greasemonkey-3.7beta1-fx.xpi?src=devhub

I'd appreciate any feedback either way.

@janekptacijarabaci

This comment has been minimized.

Show comment
Hide comment
@janekptacijarabaci

janekptacijarabaci Nov 20, 2015

Contributor

It looks good. Thank you.

Contributor

janekptacijarabaci commented Nov 20, 2015

It looks good. Thank you.

@janekptacijarabaci

This comment has been minimized.

Show comment
Hide comment
@janekptacijarabaci
Contributor

janekptacijarabaci commented Feb 12, 2016

Update: #2292 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment