New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script with @run-at document-start will be executed twice #2371

Closed
Infocatcher opened this Issue Mar 5, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Infocatcher

Infocatcher commented Mar 5, 2016

Testcase: https://gist.github.com/Infocatcher/1243f295ca93c94160ec
Install: https://gist.githubusercontent.com/Infocatcher/1243f295ca93c94160ec/raw/document-start.user.js
(and then open about:blank?UserScripts/test - should appear only one +)

// ==UserScript==
// @name        about:blank?UserScripts/test
// @namespace   dev/null
// @include     about:blank?UserScripts/test
// @run-at      document-start
// @version     1
// @grant       none
// ==/UserScript==

console.log("test: " + document.readyState);
document.body.appendChild(document.createTextNode("+"));

Tested with Greasemonkey 3.7, 3.8beta2 (Firefox 44.0.2).

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Apr 18, 2016

Collaborator

Fix merged.

Collaborator

arantius commented Apr 18, 2016

Fix merged.

@arantius arantius closed this Apr 18, 2016

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Apr 18, 2016

Collaborator

This should be fixed in build 3.8beta3; confirmation would be helpful.

https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/3.8beta3

Collaborator

arantius commented Apr 18, 2016

This should be fixed in build 3.8beta3; confirmation would be helpful.

https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/3.8beta3

@Infocatcher

This comment has been minimized.

Show comment
Hide comment
@Infocatcher

Infocatcher Apr 18, 2016

Confirmed, looks fixed for me with GM 3.8beta3 too.
Here I've tested with custom build from master branch: #2372 (comment)
Thanks again. :)

Infocatcher commented Apr 18, 2016

Confirmed, looks fixed for me with GM 3.8beta3 too.
Here I've tested with custom build from master branch: #2372 (comment)
Thanks again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment