New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the monkey menu script list #2585

Closed
arantius opened this Issue Sep 26, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@arantius
Collaborator

arantius commented Sep 26, 2017

Right now the monkey menu always lists every installed script every time.

If we keep this behavior, it should be split into "active on this page" and "the rest" sections, to make the first more relevant group more discoverable.

I've been toying with getting rid of the full-tab "manage" dialog in favor of doing all script management in the monkey menu (expanding the per-script display and options), but have not made a firm decision about that. If that decision is positive, do as above. If we keep the manage dialog, then perhaps we go back to the pre-4.0 style of only listing the active on this tab scripts.

@arantius arantius added this to the 4.x milestone Sep 26, 2017

@Sxderp

This comment has been minimized.

Show comment
Hide comment
@Sxderp

Sxderp Sep 26, 2017

Contributor

The problem I see is large lists of scripts. When drop-downs/button-menus get long it can be really inconvenient dealing with them.

Contributor

Sxderp commented Sep 26, 2017

The problem I see is large lists of scripts. When drop-downs/button-menus get long it can be really inconvenient dealing with them.

@Sxderp

This comment has been minimized.

Show comment
Hide comment
@Sxderp

Sxderp Sep 27, 2017

Contributor

Another thing to consider are the people who don't like having extra buttons in the toolbar area.

Aside from that, after mulling it over, I think doing script management through the menu could work out. There are a couple things that I think should have some consideration.

  • Instead of listing scripts for the current page in the standard button menu, create a page action button and list them there. I think this fits very nicely in what a page action should be.
  • The full list of scripts in the Money Menu should be separated by namespace submenus. That way large lists of scripts should be manageable.
Contributor

Sxderp commented Sep 27, 2017

Another thing to consider are the people who don't like having extra buttons in the toolbar area.

Aside from that, after mulling it over, I think doing script management through the menu could work out. There are a couple things that I think should have some consideration.

  • Instead of listing scripts for the current page in the standard button menu, create a page action button and list them there. I think this fits very nicely in what a page action should be.
  • The full list of scripts in the Money Menu should be separated by namespace submenus. That way large lists of scripts should be manageable.
@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Oct 18, 2017

Collaborator

Another thing to consider are the people who don't like having extra buttons in the toolbar area.

You can customize this like button like any other part of the UI, putting it into the overflow or hamburger menu. Browser Extensions get almost no UI besides the "browser action" which is a toolbar button.

create a page action button and list them there

This doesn't feel right to me. This would contain things only vaguely connected to the page. Plus you can't customize page actions out of your toolbar ;-) For some/many users this page action would ~always be visible. On mobile, page actions have to fit into a very small space. And what happens if two different extensions try to register a page action for the same page?

The full list of scripts in the Money Menu should be separated by namespace submenus

I disagree quite strongly. Namespace is an invisible property that only script authors understand; explaining to a normal user why a script is in a group would be unnecessarily difficult. This is something that you're generally not in control of as a user, scripts would appear to be in a random order more than anything else.

I think I prefer the legacy style of "active" scripts (ran on this tab) in one group, while "inactive" (did not run on this tab) ones are separate. Usually you're looking for something "running", no?

Collaborator

arantius commented Oct 18, 2017

Another thing to consider are the people who don't like having extra buttons in the toolbar area.

You can customize this like button like any other part of the UI, putting it into the overflow or hamburger menu. Browser Extensions get almost no UI besides the "browser action" which is a toolbar button.

create a page action button and list them there

This doesn't feel right to me. This would contain things only vaguely connected to the page. Plus you can't customize page actions out of your toolbar ;-) For some/many users this page action would ~always be visible. On mobile, page actions have to fit into a very small space. And what happens if two different extensions try to register a page action for the same page?

The full list of scripts in the Money Menu should be separated by namespace submenus

I disagree quite strongly. Namespace is an invisible property that only script authors understand; explaining to a normal user why a script is in a group would be unnecessarily difficult. This is something that you're generally not in control of as a user, scripts would appear to be in a random order more than anything else.

I think I prefer the legacy style of "active" scripts (ran on this tab) in one group, while "inactive" (did not run on this tab) ones are separate. Usually you're looking for something "running", no?

@Sxderp

This comment has been minimized.

Show comment
Hide comment
@Sxderp

Sxderp Oct 18, 2017

Contributor

You've made some good points. Though, I would adjust your 'ran on this tab' to be 'included/matched on this tab.' What I mean is the prominent grouping should include enabled and disabled scripts.

Contributor

Sxderp commented Oct 18, 2017

You've made some good points. Though, I would adjust your 'ran on this tab' to be 'included/matched on this tab.' What I mean is the prominent grouping should include enabled and disabled scripts.

@arantius arantius modified the milestones: 4.x, 4.1 Oct 18, 2017

@arantius arantius closed this in c194621 Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment