New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM.openInTab opens the tab in the wrong place #2672

Closed
AndersOhrt opened this Issue Nov 15, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@AndersOhrt

AndersOhrt commented Nov 15, 2017

I've upgraded to Firefox 57, and migrated my script from GM_openInTab to GM.openInTab. I have browser.tabs.insertRelatedAfterCurrent = false. When tabs are opened, they are placed incorrectly, as if insertRelatedAfterCurrent was true.

@xor10

This comment has been minimized.

Contributor

xor10 commented Nov 15, 2017

Webextensions don't have access to this setting. :(
The solution would be to create a settings page to allow the user to set this.

@AndersOhrt

This comment has been minimized.

AndersOhrt commented Nov 15, 2017

Adding another parameter to the function would also work in my case, as it is now my script is unusable.

@arantius arantius added this to the Pony milestone Nov 15, 2017

esperecyan added a commit to esperecyan/greasemonkey that referenced this issue Dec 16, 2017

esperecyan added a commit to esperecyan/greasemonkey that referenced this issue Jan 9, 2018

esperecyan added a commit to esperecyan/greasemonkey that referenced this issue Jan 16, 2018

Avoid the error which be occured by `opennerTabId` in Firefox 52 ESR.
Additionally, removes unnecessary `tabs.Tab.windowId` and `tabs.Tab.index` if `tabs.Tab.opennerTabId` exists.

These complete greasemonkey@256bf16 and resolves greasemonkey#2672 as a result.

@arantius arantius modified the milestones: Pony, 4.3 Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment