Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add custom user include/exclude settings, per-script #2728

Closed
arantius opened this issue Nov 23, 2017 · 5 comments
Closed

Re-add custom user include/exclude settings, per-script #2728

arantius opened this issue Nov 23, 2017 · 5 comments
Milestone

Comments

@arantius
Copy link
Collaborator

@arantius arantius commented Nov 23, 2017

Compare the features of old GM, and TM, and VM. Pick a nice set of those and add to GM4.

@arantius arantius added this to the 4.x milestone Nov 23, 2017
@arantius arantius removed this from the 4.x milestone Jan 19, 2018
@arantius arantius added this to the Features milestone Feb 22, 2018
@arantius arantius modified the milestones: Features, 4.6 Jun 29, 2018
@arantius
Copy link
Collaborator Author

@arantius arantius commented Jun 29, 2018

ViolentMonkey: You open a script's editor, then there's a "Settings" tab:

image

Which lets you tweak several top level values (name, run at, URLs), plus include/exclude/match/exclude-match rules; each of the latter with a (default checked) "keep original" checkbox.

@arantius
Copy link
Collaborator Author

@arantius arantius commented Jun 29, 2018

Tampermonkey:

Right in the toolbar popup offers a "..." button with an "exclude" menu item, for the current domain:
image

Also has a settings tab under the script editor:
image

With six different boxes, three display the script's include/match/exclude values, with (checked by default) "Original" checkboxes that can turn off these values, and "user" include/match/exclude" boxes, which each have an add/edit/remove button. There's helper buttons for coping the script values into a particular user value each.

@arantius arantius modified the milestones: 4.6, 4.7 Jul 9, 2018
arantius added a commit to arantius/greasemonkey that referenced this issue Jul 27, 2018
This is where I expect to put more controls: user inc/exc/match first.

Refs greasemonkey#2728
arantius added a commit to arantius/greasemonkey that referenced this issue Jul 27, 2018
arantius added a commit to arantius/greasemonkey that referenced this issue Jul 27, 2018
@arantius
Copy link
Collaborator Author

@arantius arantius commented Jul 27, 2018

See all the commits I just pushed. It looks like:

image

I want to add at least a "+" of the current domain, like exists for global excludes already, before calling this done. As always, testing of the next nightly build ( http://arantius.com/misc/gm-nightly/ ) including these is greatly appreciated!

@Eselce
Copy link
Contributor

@Eselce Eselce commented Jul 27, 2018

Is it "User" opposite to "Global"?
Hmm, probably rather opposite to script content...
Confirmed: Looks like Tampermonkey style!

@arantius
Copy link
Collaborator Author

@arantius arantius commented Jul 31, 2018

Whoops, tagged a commit in the wrong issue (#2531): c543fad

With that, I'm happy with this feature.

@arantius arantius closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.