New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to vector icon #2739

Closed
iology opened this Issue Nov 30, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@iology
Contributor

iology commented Nov 30, 2017

Tested on Firefox 57, 58

screenshot

<xul:image
  xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
  anonid="icon"
  class="icon"
  src="https://addons.cdn.mozilla.net/user-media/addon_icons/0/748-64.png?modified=1510954212"/>

The biggest icon provided by GM is not big enough. It should be at least 96x96 (192x192 or larger for high dpi displays).

Firefox can auto-sacle a big image (like 400x400) for GM, so a bigger icon always helps.

UPDATE: opened an issue for Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1422026

@arantius

This comment has been minimized.

Collaborator

arantius commented Nov 30, 2017

The first half has nothing to do with us. The second: We've got the assets we've got, I can't do much about that.

@arantius arantius closed this Nov 30, 2017

@iology

This comment has been minimized.

Contributor

iology commented Nov 30, 2017

We've got the assets we've got, I can't do much about that.

Is contribution welcome? I can try to make a bigger one for you.

@arantius

This comment has been minimized.

Collaborator

arantius commented Nov 30, 2017

We're open source, so the simple answer is yes.

I've grown pretty attached to this particular imagery over the years we've had it though so, how closely can you match the style?

@iology

This comment has been minimized.

Contributor

iology commented Dec 1, 2017

Draft: 2x

@arantius

This comment has been minimized.

Collaborator

arantius commented Dec 1, 2017

Nice. Vectors hopefully?

@arantius arantius reopened this Dec 1, 2017

@iology

This comment has been minimized.

Contributor

iology commented Dec 1, 2017

Yes, in svg format. We can also get a flatter one by removing the gradient effect.

@iology iology referenced this issue Dec 7, 2017

Merged

Use SVG icons #2749

@arantius arantius modified the milestones: 4.2, 4.3 Jan 5, 2018

@arantius

This comment has been minimized.

Collaborator

arantius commented Jan 19, 2018

Just to sanity check, what I see now. Both with Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0; before is at 9d2783f and after is at 7f6f416.

Place Before After
Toolbar screenshot from 2018-01-19 11 30 24 screenshot from 2018-01-19 11 33 27
Add-ons screenshot from 2018-01-19 11 30 56 screenshot from 2018-01-19 11 33 48
Add-ons detail screenshot from 2018-01-19 11 32 09 screenshot from 2018-01-19 11 35 41

Differences remain, but they're tiny, and the SVG form looks good at all sizes. Let's move forward!

@arantius arantius changed the title from Remote icons shown in the about:addon page to Switch to vector icon Jan 19, 2018

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Jan 19, 2018

Let's move forward!

Is there anything else, or is it just this issue needs to be closed and #2749 merged?

@arantius

This comment has been minimized.

Collaborator

arantius commented Jan 19, 2018

There's just some delay between when I make comments (real time) and when I build/test/merge/push/etc. -- the latter often bundles a few things.

@iology

This comment has been minimized.

Contributor

iology commented Jan 19, 2018

I'll keep polishing it in my spare time. :D The svg icon is undoubtedly flat because it is hard to have fine-grain control of the gradience effect without utilizing embedded rasterized image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment