Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts included with magic tld don't show up in "User scripts for this tab" #2795

Closed
stonecrusher opened this issue Jan 9, 2018 · 4 comments
Milestone

Comments

@stonecrusher
Copy link

stonecrusher commented Jan 9, 2018

Firefox 57.0.4 (64-Bit)
Greasemonkey 4.1

The title says it all... example:
// @include http://*.imdb.tld/title/tt*

The script is correctly applied but in the greasemonkey popup it shows under "Other user scripts" instead of "User scripts for this tab". So one can't see all scripts which are active on the current tab.

Works fine when using
// @include http://*.imdb.com/title/tt*

/edit
I didn't remember my version of the example script above was modified. It looks like magic tld isn't supported at all at the moment.

/edit2
Simple scripts using magic tld in @include work as intended (but not @match, see #2096).
Summary: I just had some weird issues with the script mentioned above and I'll investigate further.

@Sxderp
Copy link
Contributor

Sxderp commented Jan 9, 2018

Not sure what 'magic tld' is supposed to be, but in the code // TODO: Accurate ".tld" support; blocked by http://bugzil.la/1315558.

@stonecrusher
Copy link
Author

@Sxderp
See https://wiki.greasespot.net/Magic_TLD
And thanks for the info! Looking at the FF bug, arantius is already aware of it.

@arantius arantius reopened this Jan 9, 2018
@arantius
Copy link
Collaborator

arantius commented Jan 9, 2018

I'm seeing .tld not work at all right now. Checking ...

@arantius arantius closed this as completed Jan 9, 2018
@arantius arantius added this to the 4.2 milestone Jan 9, 2018
arantius added a commit to arantius/greasemonkey that referenced this issue Jan 9, 2018
@stonecrusher
Copy link
Author

I'm sorry, you are right. I thought I was wrong because my testing environment here is a mess and caused lots of confusion (plus I didn't know about the difference of @include and @match).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants