New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More monkey background color glitches #2833

Closed
NoneGiven opened this Issue Feb 5, 2018 · 41 comments

Comments

Projects
None yet
4 participants
@NoneGiven
Contributor

NoneGiven commented Feb 5, 2018

Version: 4.3beta4
Platform: FF58 on Windows 10

(1) Scroll up or down in your user script list, then click a script to open its details pane. During the transition animation to and from the details pane, the bottom section will be messed up. This only happens if you scroll first.

image

(2) In the script details pane, mouse over and then off the Uninstall item. It will not properly return to the "unselected" look when you mouse off.

image

Edit: The precise behavior of the second one can apparently vary between displays/machines, but there's some weirdness either way.

@arantius arantius added this to the 4.3 milestone Feb 5, 2018

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 6, 2018

It's a Windows thing. Pretty sure the transition effect is what makes it prominent, but it's not something we can eliminate altogether. Mozilla needs to fix their rendering engine. This is much better than what it was at first, and is actually still readable. I'm not sure what can be done short of going completely back to the old style (which probably still had glitches, just less noticeable).

See #2822 (comment) for links.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

Does anyone have the same issue under windows system as me?
I get some of the text strings clipped at the bottom (such that the baseline and lower is missing).
I've got the feeling, that it's just the translated strings, but it looks really strange...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 6, 2018

Does anyone have the same issue under windows system as me?

Not the same as pictured above? Could you post a picture?

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

Not the same as pictured above? Could you post a picture?

I've managed to show at least a part of that:

It also affects the New script... part and the 3 links at the bottom, as well as the submenus...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 6, 2018

Are you using FF with some theme or are you using a fork? If it's a fork them it might be because of the -moz (which are really great and should be added to the standard...) attributes / values in the CSS.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

That one was the developers ed. Let me try out my main version...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 6, 2018

I don't think that would make a difference. It might, but last I checked there wasn't much different between developer edition and release. If I recall correctly it was more like a glorified beta. Some additional features that eventually get moved into release.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

Nope. GM 4.3beta4 with

  • 58.0.1 (64-Bit) Quantum
  • 59.0b6 (64-Bit) Developer Edition (aurora)
@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

And as I can see it, it's only the locale strings. Not the script names. And they seem to be adjusted a bit lower (compared to the names and/or the icons)...

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

I used to have it in order to compare FF 56.x and FF 57.x. No longer today. Now it's just to have two seperate installations. They don't differ much!

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 6, 2018

If you switch to English does the problem persist? It could be the characters are using more 'line-height' or some such.

Other things I'd suggest and see if it persists. Unfortunately I don't have access to FF57+ atm and it'd be a PIA to configure something up right now.

  • Forcibly set static strings
  • Add after="{something}" to one of the a tags (adds text in the same area as the arrow)
  • Add next-menu to one of the a tags (will add an arrow to the end)
  • Change the name of a script to something with non-ascii characters (and see if it breaks)

Some other tidbits.
Windows 10?
Scaling setting? Unless I'm mistaken your text looks larger than what's in the OP. May be related.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

If you switch to English does the problem persist? It could be the characters are using more 'line-height' or some such.

Have you ever tried to switch the FF language pack? I'm still stuck with my german installation, but working on it. Settings ->(preferred) Language doesn't do anything (but selecting english pages? dunno).
EN-US language package installed => gave me a AddOns tab Sprachen (Languages), but didn't change a lot.
Still working on it...

Also checking things similar to those you mentioned (I will change sth. with my eclipse/GitHub system and install it temporarily - that worked already!) Maybe tonight...

8.1 (refused to upgrade 10)
probably no scaling (that graphic may be about 1/5th height and 1/5th width of the screen (not too big)

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 6, 2018

Still working on it...

What's your Windows set at? I'm pretty sure there's a configuration option in FF that uses the OS locale and disregards pretty much all other settings. Might be behind about:config or somesuch.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 6, 2018

Must be %LOCALE%...

... did not work. Would probably only affect linked pages in about:config. Although help refers to https://support.mozilla.org/de/products/firefox?as=u&utm_source=inproduct. I don't want to change my OS' setting...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 8, 2018

... did not work.

Almost missed this, only saw it because I almost never close tabs and happen to click on this particular tab. If you have an update just post another message.

Anyway I'll try installing a windows VM under a different language and see if I can reproduce. Sometime this weekend.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 8, 2018

I know, that I didn't produce a new notification. I did that, because there was almost no time between my posts (just your reply), and my try was almost immediately blown up (just saw the %LOCALE% entries in the about:config and made a (false) guess). I'm also heavily busy now, maybe tomorrow, or at the weekend as well for me...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 16, 2018

I can't seem to reproduce the offset error. I've tried with different FF language installations, Windows display settings, FF font sizes, UI compact settings.

This is on Windows 10 1709.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 16, 2018

Maybe it's a Windows 8.1 thing? The data is correct, just the alignment fails...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Feb 16, 2018

Could be. I don't have any Windows 8 systems to test. Nor can I get ahold of one.

@arantius

This comment has been minimized.

Collaborator

arantius commented Feb 16, 2018

The issues I've seen most recently are minor but recently still present, Windows 7.

@arantius

This comment has been minimized.

Collaborator

arantius commented Feb 22, 2018

Right now on Win7, I see:

  1. Every time the "uninstall" entry is deactivated, it retains (most of) its grey active background.
  2. Scroll down the main view, click into any sub-view; a bunch of the dialog turns black while it's animating in, and back out. Subsequent switches look OK.

@arantius arantius changed the title from More monkey menu visual glitches to More monkey background color glitches Feb 23, 2018

@Eselce

This comment has been minimized.

Contributor

Eselce commented Feb 28, 2018

Number 1 seems to be gone, but now, there is a different grey active background (just baseline). Maybe only Win 8.1 (then it's okay, just broken).

@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 7, 2018

These visual glitches are unfortunate, but only cosmetic, so I'm deferring any remaining fixes to the next release.

@arantius arantius modified the milestones: 4.3, 4.4 Mar 7, 2018

@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 29, 2018

Working on this here:

master...arantius:monkey-menu-rewrite

It doesn't have the brand new "scroll only the scripts" feature, but otherwise is a lot less code to do the same things. And fingers crossed might address visual glitches.

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 29, 2018

Can't test at the moment, but there are two things with the menus that I'd like to know.

  1. Does it support multiple different "next" or "arrow" menus? For example if #2770 is added, will transitions work properly going to the different menus?
  2. Does it support nested "next" or "arrow" menus? Currently there isn't a use for this but it was something I figured might be useful down the line. For example, adding user includes / matches might be an extra nested menu.
@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 29, 2018

Ah, a third thing.

  1. Does rv-unless evaluate more than once? If you have some scripts, then remove them all, does the visual 'break?' That is, do all the <hr> lines get removed properly when examining the 'top' menu?
@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 29, 2018

Oh, I'm missing the little ">" arrows to indicate "will open a submenu".

Does it support multiple [sub] menus?

No. I don't build support for anything that isn't needed now. I can imagine how to do this with very few changes though.

Does it support nested [sub menus?

No, same thing.

If you have some scripts, then remove them all, does the visual 'break?'

This is a problem with the menu today, before any changes. E.g., test profile...

Before:
image

After uninstalling the only installed script, and going back "up":
image

Haven't tested yet in this branch, but I expect it will work.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Mar 29, 2018

I guess, there's a <hr> missing in the submenu (below the title)...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 29, 2018

This is a problem with the menu today, before any changes. E.g., test profile...

OH. I forgot, I had a change in my monkey-menu.js that I had set to ignore. This issue is caused by this line (in current code)

if (script.uuid == scriptUuid) {
gTplData.userScripts.splice(i, 1);
break;
.

The active / inactive scripts are never removed from the array.

@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 29, 2018

Still to do: test on Windows, to see if it's glitchy. Current state:

image

As of 36d4794.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Mar 29, 2018

Win 8.1 was just fine (just the usual glitches). As of 36d4794.

Well, hmm, the third link at the bottom (Get user scripts) is not withing the menu, it is scrolled (without scrollbar) when moving down.

Also (in the submenu), two horiz. lines were removed (below the header and below the details).

@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 29, 2018

Well, hmm, the third link at the bottom (Get user scripts) is not withing the menu, it is scrolled (without scrollbar) when moving down.

Can you elaborate? I don't know what you mean.

Also (in the submenu), two horiz. lines were removed (below the header and below the details).

Yep, whoops.

That said, on Win7, I'm still seeing glitchiness, but not as much as before. Only while scrolling the scripts (the only thing that scrolls), and isolated to the newly visible elements.

Also just noticed: mouseout should un-focus.

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 29, 2018

Maybe it's just me, but I feel like the whitespacing is off (there's less of it) around each menu item. If you look at a native FF menu there's actually quite a bit of whitespace.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Mar 29, 2018

I don't know, if it's a Win 8.1 (misrendering) thing, but it was a bit unclear:

the third link at the bottom (Get user scripts) is not withing the menu, it is scrolled (without scrollbar) when moving down.

Can you elaborate? I don't know what you mean.

After opening the menu, Get user scripts is not shown (it's virtually below the menu window). When I move the mouse down below Greasemonkey Wiki, the menu scrolls (although there's no scroll bar), so that I can see the last line, but at the top, Greasemonkey is active disappears.

This is a sign of not having enough space for the menu items plus the fixed space for user script names.

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 29, 2018

Looking at the latest commit, he made the scroll bar section too large (380px). The latest master has it set to 350px to fix the nested scroll bar issue.

@Eselce

This comment has been minimized.

Contributor

Eselce commented Mar 30, 2018

Oh, if it's the old one, then it should be okay...

BTW: Is it just me, maybe I'm biased, but if find it pretty unusual to have Export before Import. I feel like having a default order of New / Open / Save and Import / Export. While it's still just convention...

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 30, 2018

Oh, if it's the old one, then it should be okay...

I meant, latest on Greasemonkey main branch.

Also: Whitespace? (before - after)
before-after

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented Mar 30, 2018

Comparison of native FF back button hover (above) and GM new back button hover. Native FF has a margin around it.

backbutton

@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 30, 2018

pretty unusual to have Export before Import

Mostly shrug, but any given user needs to export before they can import?

@Eselce

This comment has been minimized.

Contributor

Eselce commented Mar 30, 2018

pretty unusual to have Export before Import

Mostly shrug, but any given user needs to export before they can import?

I can easily follow that reasoning, but when I look around, it seems, that the natural order is quite often (if not always) New / Open / Save (as) / Import / Export. Whatever the reason is, I don't really know...

@arantius

This comment has been minimized.

Collaborator

arantius commented Mar 30, 2018

I don't think we can actually fix this, it's Firefox that's broken:

https://bugzilla.mozilla.org/show_bug.cgi?id=1418677#c20

So I'll address the general appearance items called out above and call this done.

arantius added a commit to arantius/greasemonkey that referenced this issue Mar 30, 2018

arantius added a commit to arantius/greasemonkey that referenced this issue Mar 30, 2018

arantius added a commit to arantius/greasemonkey that referenced this issue Mar 30, 2018

@arantius arantius closed this in 237e718 Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment