Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Exceptions in GM 4.x #2843

Closed
kekkc opened this Issue Feb 11, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@kekkc
Copy link

kekkc commented Feb 11, 2018

Hi all,

this is known, but I haven't find an issue for it. We absolutely need global exceptions again (sites where no scripts should be executed, e.g. banking sites...).

Apart from the already implemented save button in editor, this was the most prominent feature I missed after the transition from GM3>GM4.

global exceptions

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Feb 11, 2018

Agreed. I absolutely want this plus per-script user include/exclude settings.

@arantius arantius added this to the Features milestone Feb 22, 2018

@arantius arantius modified the milestones: Features, 4.6 Jun 29, 2018

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Jun 29, 2018

Just for reference; the above but in English:

image

arantius added a commit to arantius/greasemonkey that referenced this issue Jun 29, 2018

Add "Greasemonkey Options" submenu.
Currently empty besides a TODO.

Refs greasemonkey#2843

arantius added a commit to arantius/greasemonkey that referenced this issue Jun 29, 2018

arantius added a commit to arantius/greasemonkey that referenced this issue Jun 29, 2018

Rename "is enabled" to "options".
The enabled bit is really just the first option.  Good place to handle all the other "save these user specified values".

Refs greasemonkey#2843

arantius added a commit to arantius/greasemonkey that referenced this issue Jun 29, 2018

Round trip global excludes through options.js.
Saved in local storage, passed from bg -> monkey menu -> bg.

Refs greasemonkey#2843

arantius added a commit to arantius/greasemonkey that referenced this issue Jun 29, 2018

@Cerberus-tm

This comment has been minimized.

Copy link

Cerberus-tm commented Jun 30, 2018

Wow, this looks great!

@arantius

This comment has been minimized.

Copy link
Collaborator

arantius commented Jul 2, 2018

I don't know what "this" you're referring to, but the images above are GM 3. What I added recently (in a dev branch) to GM 4 is:

image

arantius added a commit to arantius/greasemonkey that referenced this issue Jul 2, 2018

@arantius arantius closed this in 5ea7746 Jul 2, 2018

@Cerberus-tm

This comment has been minimized.

Copy link

Cerberus-tm commented Jul 2, 2018

Oh, I should have noticed, what with the editor section and all. But the global excludes are great! I'll enjoy using that function for sensitive/difficult pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.