New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect script version/description in script submenu #2963

Closed
Klaster1 opened this Issue May 26, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Klaster1

Klaster1 commented May 26, 2018

What happens:
Previous script version/description is shown for current opened script submenu.

How to reproduce:

  1. Install several scripts with description in meta.
  2. Navigate to script 1. Remember what description says.
    image
  3. Navigate back using the arrow left to the script title.
  4. Open another script submenu, see this:
    image

The second script description should look like this:
image

All of the scripts above were installed at least a week ago.

GM version: 4.4.0
FF version: 60.0.1

@arantius arantius added the confirmed label May 27, 2018

@arantius arantius added this to the 4.5 milestone May 27, 2018

@Sxderp

This comment has been minimized.

Contributor

Sxderp commented May 29, 2018

The problem is the use of rv-if.

<p rv-if="activeScript.description">
<b>{'description'|i18n}</b> {activeScript.description}
</p>
<p rv-if="activeScript.version">
<b>{'version'|i18n}</b> {activeScript.version}
</p>
<p rv-if="activeScript.homePageUrl">
<a rv-href="activeScript.homePageUrl">{'homepage'|i18n}</a>
</p>

Changing to rv-show resolves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment