Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag'n' drop into AOM (two install dialogs), Private Browsing: The icon (enabled/disabled) #1789

Closed

Conversation

janekptacijarabaci
Copy link
Contributor

1

2

@Ventero
Copy link
Contributor

Ventero commented Aug 15, 2013

Your patch for drag & drop fails when the user drops a userscript as well as a normal addon (or any other non-userscript file) onto the addons manager at the same time (no install dialog is displayed in that case, since the original handler is called, which calls .preventDefault() on the event, thus preventing the call to service#shouldLoad).

Instead, the issue can be properly fixed by simply calling aEvent.preventDefault(); at the end of GM's gDragDrop.onDrop.

Edit: See also #1663 for a discussion on why all of this is necessary.

@janekptacijarabaci
Copy link
Contributor Author

You are right, thank you. Please still correct me if I am wrong :-)

@janekptacijarabaci janekptacijarabaci changed the title Drag'n' drop into AOM (two install dialogs), Greasemonkey = disabled (button "Install Script" not works), Private Browsing: The icon (enabled/disabled), GM_getResourceText: if missing resource name, Editing a script - an old bug is back again Drag'n' drop into AOM (two install dialogs), Greasemonkey = disabled (button "Install Script" not works), Private Browsing: The icon (enabled/disabled) Jul 31, 2014
@janekptacijarabaci janekptacijarabaci changed the title Drag'n' drop into AOM (two install dialogs), Greasemonkey = disabled (button "Install Script" not works), Private Browsing: The icon (enabled/disabled) Drag'n' drop into AOM (two install dialogs), Private Browsing: The icon (enabled/disabled) Jul 31, 2014
@janekptacijarabaci
Copy link
Contributor Author

New Issue / Pull Request: #1980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants