Drag'n' drop into AOM (two install dialogs), Private Browsing: The icon (enabled/disabled) #1789

Closed
wants to merge 6 commits into
from

Projects

None yet

2 participants

@janekptacijarabaci
Contributor

1

2

@Ventero
Contributor
Ventero commented Aug 15, 2013

Your patch for drag & drop fails when the user drops a userscript as well as a normal addon (or any other non-userscript file) onto the addons manager at the same time (no install dialog is displayed in that case, since the original handler is called, which calls .preventDefault() on the event, thus preventing the call to service#shouldLoad).

Instead, the issue can be properly fixed by simply calling aEvent.preventDefault(); at the end of GM's gDragDrop.onDrop.

Edit: See also #1663 for a discussion on why all of this is necessary.

@janekptacijarabaci
Contributor

You are right, thank you. Please still correct me if I am wrong :-)

janekptacijarabaci Private Browsing: Click on the icon (+ popup menu: Enabled)
... and the icon will not change
0d693d9
@janekptacijarabaci janekptacijarabaci changed the title from Drag'n' drop into AOM (two install dialogs), Greasemonkey = disabled (button "Install Script" not works), Private Browsing: The icon (enabled/disabled), GM_getResourceText: if missing resource name, Editing a script - an old bug is back again to Drag'n' drop into AOM (two install dialogs), Greasemonkey = disabled (button "Install Script" not works), Private Browsing: The icon (enabled/disabled) Jul 31, 2014
@janekptacijarabaci janekptacijarabaci changed the title from Drag'n' drop into AOM (two install dialogs), Greasemonkey = disabled (button "Install Script" not works), Private Browsing: The icon (enabled/disabled) to Drag'n' drop into AOM (two install dialogs), Private Browsing: The icon (enabled/disabled) Jul 31, 2014
@janekptacijarabaci
Contributor

New Issue / Pull Request: #1980

@janekptacijarabaci janekptacijarabaci deleted the janekptacijarabaci:patch-2 branch Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment