Suggestion: The dialog resizing (for Windows OS), the template is not wrapped, style clean up #2194

Closed
wants to merge 6 commits into
from

Projects

None yet

3 participants

@janekptacijarabaci
Contributor

Ad #2191
The suggestion (for example).

1
2
3
4

@arantius
Collaborator
arantius commented Jun 5, 2015

I don't understand. These grippies are not in the kind of place that makes sense, I can't understand what they're each for.

@janekptacijarabaci
Contributor

Unfortunately, also I do not understand. What are those arrows? Arrows point to the <resizer> element - this allows you to stretch the window (in this case, horizontally).
I don't know how to do better...

@arantius
Collaborator

Sorry I still don't understand this. The window can be resized just like any other, by its corner. Long text is truncated. Why this change?

@arantius arantius closed this Aug 19, 2015
@janekptacijarabaci
Contributor

The window can be resized just like any other, by its corner.

Confirmed on:
Ubuntu 15.04

Not confirmed on:
Windows 7/8.1 :-)
(windows are modal windows - the window resizing doesn't work)

And then I suggested: "The template is not wrapped". What is your opinion on this?

@janekptacijarabaci janekptacijarabaci changed the title from Suggestion: The dialog size, resizing, the template is not wrapped, clean up to Suggestion: The dialog resizing, the template is not wrapped, style clean up Aug 20, 2015
@janekptacijarabaci janekptacijarabaci changed the title from Suggestion: The dialog resizing, the template is not wrapped, style clean up to Suggestion: The dialog resizing (for Windows OS), the template is not wrapped, style clean up Aug 20, 2015
@arantius
Collaborator

I don't know what "the template is not wrapped" means.

@janekptacijarabaci
Contributor

https://github.com/greasemonkey/greasemonkey/pull/2194/files#diff-bb4d6a2d4a58244882529c2436edfe21R53

I'm sorry for the big "commit". I can do better (resizing the window, new script template, fix typo/style clean up...). It was just the suggestion (for simplicity).

Now:
1

The suggestion:
2

@arantius
Collaborator

Oh of course that's what you mean by "the template", your earlier screenshots were just overly cropped. Great.

Also, yes. Windows won't let you resize this window, but there's no reason to want that behavior.

@arantius arantius reopened this Aug 21, 2015
@arantius arantius added this to the 3.5 milestone Aug 21, 2015
@arantius arantius added a commit to arantius/greasemonkey that referenced this pull request Oct 1, 2015
@arantius arantius Don't wrap the template textarea, allow resize options window.
Refs #2194
49b1cc8
@arantius
Collaborator
arantius commented Oct 1, 2015

49b1cc8 is only two lines and gets quite close to this, what do you think?

As far as I can tell the only thing it doesn't do is allow resizing when clicking the "options" button in the AOM.

@janekptacijarabaci
Contributor

It's not occurred to me :-)

As far as I can tell the only thing it doesn't do is allow resizing when clicking the "options" button in the AOM.

That's what this trick does:
https://bugzilla.mozilla.org/show_bug.cgi?id=267950#c9

install.rdf:

<em:optionsURL>javascript:opener.openDialog('chrome://greasemonkey/content/options.xul','','modal,resizable');window.close();</em:optionsURL>

Confirmed on:
Windows, Ubuntu
e10s off/on

@arantius
Collaborator

Calling this done, filed #2300 to track the bit that isn't.

@arantius arantius closed this Oct 14, 2015
@jerone
Contributor
jerone commented Oct 16, 2015

Maybe force not wrapping lines in the "New User Script" dialog "Includes" and "Excludes" settings. Makes the "One per line" comment clearer.

@janekptacijarabaci janekptacijarabaci deleted the janekptacijarabaci:dialogSizeResizing_templateIsNotWrapped branch Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment