Tooltip improvements #2418

Merged
merged 1 commit into from Aug 19, 2016

Projects

None yet

3 participants

@janekptacijarabaci
Contributor
janekptacijarabaci commented Aug 6, 2016 edited
  1. Commands: Add localized script name (instead script name)
  2. The tooltip (+ list of scripts): Add information about setting @noscript @noframes
@arantius arantius added this to the 3.9 milestone Aug 6, 2016
@arantius arantius merged commit ab14abe into greasemonkey:master Aug 19, 2016
@janekptacijarabaci janekptacijarabaci deleted the janekptacijarabaci:tooltip_improvements branch Aug 19, 2016
@darkred
darkred commented Aug 30, 2016 edited
  1. The tooltip (+ list of scripts): Add information about setting @noscript

@janekptacijarabaci, of course you meant @noframes (there's no @noscript).

Could you please explain to me what the values Active (frames) x/y/z in the tooltip mean?
The relevant row in browser.js is 485-486, i.e.

      var activeFrames = runsFramedNoframesDisable + "/"
                         + runsFramedEnable + "/" + runsFramed.length;

For reference I quote from here:

// @noframes metadata imperative:

When present, this imperative restricts the execution of the script. The script will run only in the top-level document, never in nested frames. It takes no arguments, it is either present or not present. This is off (scripts run in frames) by default.

@janekptacijarabaci
Contributor
janekptacijarabaci commented Aug 31, 2016 edited

Of course you meant @noframes (there's no @noscript).

Yes. Thank you :-)

Active (frames) x/y/z

x - is the count of active scripts in (nested) frames - according to url (without option @noframes)
y - is the count of active scripts in (nested) frames - according to url
z - is the count of scripts in (nested) frames - according to url

e.g.: http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe

It should be in the documentation (in the future)...
#2396 (comment)

@darkred
darkred commented Aug 31, 2016

Thanks a lot for your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment