Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Display a modal when saving a user script in the editor #2858
referenced this pull request
Feb 17, 2018
I see in an email update (but can't find anywhere else) that @Sxderp said:
I plan on merging this, but after some other work of mine -- I'll have to resolve merge conflicts at that time.
While we're waiting: does CodeMirror not have something to do (possibly modal) dialogs already? Maybe https://github.com/codemirror/CodeMirror/tree/master/addon/dialog ?
If not is there a tidy general JS "modal dialog" component somewhere that we could simply reuse, rather than writing support for it from scratch? A few moments of searching finds me:
Which seem decent. The smaller/lighter the better IMO. Anything pre-existing with a documented API is good.