Store iconBlob as an array buffer #2909
Conversation
Ensures the following conditional doesn't throw if foundDetails is null or undefined.
| @@ -92,6 +99,11 @@ async function loadUserScripts() { | |||
| }; | |||
| }).then(loadDetails => { | |||
| let savePromises = loadDetails.map(details => { | |||
| if (details.iconBlob && ! (details.iconBlob instanceof Blob)) { | |||
| let info = details.iconBlob; | |||
| details.iconBlob = new Blob([info.buffer], {'type': info.type}); | |||
There was a problem hiding this comment.
Why do we need to do this both here and line 68-72? Does one or the other only handle updating things already saved the other way?
There was a problem hiding this comment.
@arantius the 68-72 portion deals with the instance where we search the database for a script with an existing id in order to update it. Before we can update the just fetched script we need to change the array buffer into a blob.
The other is for when loading the scripts from initial start. Before we do anything with them we transform the array buffer into a blob.
Both instance ensure we don't do anything if the saved object contains a blob (meaning we're still in the progress of migrating).
The lines at 68-72 wouldn't be required if the script wasn't fetched from the database. But instead found from the already loaded scripts.
Either way, once the icons are stored as array buffers you need to convert them to blobs as soon as they're fetched from the database so you don't have inconsistencies or weird errors in other places.
There's something wrong with storing the icon as a blob. I don't know exactly what as blobs should be supported. The error was easily reproducible using a bare script with some random iconurl. By switching to storing as an array buffer I was unable to reproduce the issue linked. The I did encounter the minor display issue as noted in comment 0. |
|
Merged by hand. |
See greasemonkey#2909 where this was fixed only for `@icon`. Now, store every blob in IndexedDB as an ArrayBuffer instead. Parse it back into a blob in memory. This is a work around which should be unnecessary but helps alleviate real bugs. Fixes greasemonkey#2943
fixes #2908
There's a very minor bug with this PR that I can't seem to fix. On startup the scripts are force re-saved (updated eval content version) in order to save the buffer into the database. However, on this initial load the icons break and become Firefox placeholders. Reloading Greasemonkey resolves the issue. Further, the issue does not occur if you force re-save (update eval content version) again (for future updates).
Perhaps someone else can figure out the above bug. But since it occurs once I don't think it's that big of a deal.