Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Store iconBlob as an array buffer #2909
There's a very minor bug with this PR that I can't seem to fix. On startup the scripts are force re-saved (updated eval content version) in order to save the buffer into the database. However, on this initial load the icons break and become Firefox placeholders. Reloading Greasemonkey resolves the issue. Further, the issue does not occur if you force re-save (update eval content version) again (for future updates).
Perhaps someone else can figure out the above bug. But since it occurs once I don't think it's that big of a deal.
There's something wrong with storing the icon as a blob. I don't know exactly what as blobs should be supported. The error was easily reproducible using a bare script with some random iconurl.
By switching to storing as an array buffer I was unable to reproduce the issue linked. The I did encounter the minor display issue as noted in comment 0.