Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll only userscript section in Monkey Menu #2913

Merged

Conversation

Sxderp
Copy link
Contributor

@Sxderp Sxderp commented Mar 18, 2018

fixes #2809

@arantius arantius added this to the 4.4 milestone Mar 18, 2018
@arantius
Copy link
Collaborator

I'm not convinced I want this; got screenshots before and after?

Also: you can probably get away with much less code (and less changed) by switching the divs from rv-hide to rv-if, then using CSS to hide consecutive hrs?

@Sxderp
Copy link
Contributor Author

Sxderp commented Mar 23, 2018

Also: you can probably get away with much less code...

I need to test the following, but I don't think so. Unless I'm mistaken rv-if is evaluated once. So the DOM won't update as you add or remove scripts. Thus you'd have a

<hr>
<div></div>
<hr>

Thus the <hr> are not consecutive.

@Sxderp
Copy link
Contributor Author

Sxderp commented Mar 23, 2018

For note, right now the code scrolls all the scripts under one scrollbar. I just thought it might be decent to scroll the two sections individually. That way, say you have 100 scripts, you can know right away if the script ran on the page rather than having to scroll up to look at the heading.

@Sxderp
Copy link
Contributor Author

Sxderp commented Mar 23, 2018

To clarify my above. "right now this PR..."

@Eselce
Copy link
Contributor

Eselce commented Mar 23, 2018

Appreciating the idea of scrolling only the user scripts (or even only the "other" user scripts)...

@Sxderp
Copy link
Contributor Author

Sxderp commented Mar 24, 2018

Either both should be scrolled or none. For example if you have a lot of active scripts it seems weird to scroll the entire content to go through them but not have to scroll the entire content for the other scripts (nested scrollbars suck).

@Eselce
Copy link
Contributor

Eselce commented Mar 24, 2018

All of which are active on the current page/tab? Okay, may happen, if you have many universal scripts (@include *). For me, I normally have a max of 5 active scripts on a page, much more are inactive on that page (but activated).
As I said, all user scripts (both sections) being scrolled is a good option.

@Sxderp Sxderp force-pushed the scroll-only-user-scripts-in-menu branch from be75390 to 52985c5 Compare March 24, 2018 13:55
@Sxderp
Copy link
Contributor Author

Sxderp commented Mar 24, 2018

Pictures

before-after

@Eselce
Copy link
Contributor

Eselce commented Mar 24, 2018

Okay, that's focused and clear enough...

@arantius arantius merged commit a62d138 into greasemonkey:master Mar 28, 2018
@Sxderp Sxderp deleted the scroll-only-user-scripts-in-menu branch March 31, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Improve the Monkey Menu when many scripts are installed
3 participants