Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility semantics and labels. #3058

Merged
merged 1 commit into from Sep 9, 2020
Merged

Conversation

jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Oct 23, 2019

This makes Greasemonkey far more usable by screen reader users.

Even though keyboard navigation is implemented for the Monkey Menu, this change exposes it as buttons, rather than menu + menuitems. This is because unlike most menus, this menu contains headings, which doesn't fit the ARIA menu pattern. This way, screen reader users will be able to browse this like any other document and will be made aware of (and able to jump to) the headings.

This makes Greasemonkey far more usable by screen reader users.

Even though keyboard navigation is implemented for the Monkey Menu, this change exposes it as buttons, rather than menu + menuitems.
This is because unlike most menus, this menu contains headings, which doesn't fit the ARIA menu pattern.
This way, screen reader users will be able to browse this like any other document and will be made aware of (and able to jump to) the headings.
@arantius arantius added this to the 4.10 milestone Oct 25, 2019
@MarcoZehe
Copy link

MarcoZehe commented May 14, 2020

Is there any way to move this forward? This PR has been sitting here uncommented and unreviewed for several months.

@arantius arantius merged commit 7c0ed7a into greasemonkey:master Sep 9, 2020
@arantius
Copy link
Collaborator

arantius commented Sep 9, 2020

I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants