Add accessibility semantics and labels. #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Greasemonkey far more usable by screen reader users. Even though keyboard navigation is implemented for the Monkey Menu, this change exposes it as buttons, rather than menu + menuitems. This is because unlike most menus, this menu contains headings, which doesn't fit the ARIA menu pattern. This way, screen reader users will be able to browse this like any other document and will be made aware of (and able to jump to) the headings.
This was referenced Oct 23, 2019
Closed
|
Is there any way to move this forward? This PR has been sitting here uncommented and unreviewed for several months. |
|
I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Greasemonkey far more usable by screen reader users.
Even though keyboard navigation is implemented for the Monkey Menu, this change exposes it as buttons, rather than menu + menuitems. This is because unlike most menus, this menu contains headings, which doesn't fit the ARIA menu pattern. This way, screen reader users will be able to browse this like any other document and will be made aware of (and able to jump to) the headings.