Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional simple editor which uses a plain textarea. #3060

Merged
merged 1 commit into from Sep 9, 2020

Conversation

jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Oct 24, 2019

This is needed by screen reader users, as CodeMirror is unfortunately not accessible. Having a separate editor is not ideal, nor is the missing functionality for screen reader users. Nevertheless, this is far better than a completely inaccessible editor. This at least allows screen reader users to read the content and do basic editing.

A more ideal alternative would be switching to Monaco, which is accessible. This would avoid the need for a separate editor and provide advanced functionality for all users. I'm not sure if that is feasible, though.

@jcsteh
Copy link
Contributor Author

jcsteh commented Oct 24, 2019

I discovered that this broke when creating a new script, as the ?simple query string wasn't passed in that case. Fixing that was going to introduce more ugliness, so I refactored so that the options are fetched in edit-user-script. That should also make it easier to add additional editor configurability in future.

@jcsteh jcsteh closed this Oct 24, 2019
@jcsteh jcsteh reopened this Oct 24, 2019
This is needed by screen reader users, as CodeMirror is unfortunately not accessible.
Having a separate editor is not ideal, nor is the missing functionality for screen reader users.
Nevertheless, this is far better than a completely inaccessible editor.
This at least allows screen reader users to read the content and do basic editing.
@arantius arantius added this to the 4.10 milestone Oct 25, 2019
@arantius
Copy link
Collaborator

arantius commented Oct 25, 2019

Monaco looks interesting and this example makes me think that if we include its files the right way, we can load it from a web extension.

@MarcoZehe
Copy link

MarcoZehe commented May 14, 2020

Any way to move this forward? This PR has been sitting here largely uncommented and unreviewed for several months.

@arantius arantius merged commit 5be1d6c into greasemonkey:master Sep 9, 2020
@arantius
Copy link
Collaborator

arantius commented Sep 9, 2020

I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it.

arantius added a commit that referenced this pull request Sep 11, 2020
Fill the screen, monospace font.

Refs #3060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants