Add an optional simple editor which uses a plain textarea.#3060
Merged
arantius merged 1 commit intogreasemonkey:masterfrom Sep 9, 2020
Merged
Add an optional simple editor which uses a plain textarea.#3060arantius merged 1 commit intogreasemonkey:masterfrom
arantius merged 1 commit intogreasemonkey:masterfrom
Conversation
d788177 to
e394a6d
Compare
Contributor
Author
|
I discovered that this broke when creating a new script, as the ?simple query string wasn't passed in that case. Fixing that was going to introduce more ugliness, so I refactored so that the options are fetched in edit-user-script. That should also make it easier to add additional editor configurability in future. |
This is needed by screen reader users, as CodeMirror is unfortunately not accessible. Having a separate editor is not ideal, nor is the missing functionality for screen reader users. Nevertheless, this is far better than a completely inaccessible editor. This at least allows screen reader users to read the content and do basic editing.
e394a6d to
304f55c
Compare
Collaborator
|
Monaco looks interesting and this example makes me think that if we include its files the right way, we can load it from a web extension. |
|
Any way to move this forward? This PR has been sitting here largely uncommented and unreviewed for several months. |
Collaborator
|
I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it. |
arantius
added a commit
that referenced
this pull request
Sep 11, 2020
Fill the screen, monospace font. Refs #3060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed by screen reader users, as CodeMirror is unfortunately not accessible. Having a separate editor is not ideal, nor is the missing functionality for screen reader users. Nevertheless, this is far better than a completely inaccessible editor. This at least allows screen reader users to read the content and do basic editing.
A more ideal alternative would be switching to Monaco, which is accessible. This would avoid the need for a separate editor and provide advanced functionality for all users. I'm not sure if that is feasible, though.