Skip to content

Commit

Permalink
[BUGFIX] Re-enable GCS Docs Integration test (#9237)
Browse files Browse the repository at this point in the history
  • Loading branch information
Shinnnyshinshin committed Jan 19, 2024
1 parent f359a18 commit 52c06f3
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 13 deletions.
1 change: 0 additions & 1 deletion ci/checks/check_integration_test_gets_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"tests/expectations/core/test_expect_column_mean_to_be_positive.py",
"tests/integration/docusaurus/expectations/examples/column_aggregate_expectation_template.py",
"tests/integration/docusaurus/expectations/examples/multicolumn_map_expectation_template.py",
"tests/integration/docusaurus/setup/configuring_data_docs/how_to_host_and_share_data_docs_on_gcs.py",
]


Expand Down
10 changes: 5 additions & 5 deletions great_expectations/checkpoint/types/checkpoint_result.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,14 @@ def list_validation_results(
Args:
group_by: Specify how the ExpectationValidationResults should be grouped.
Valid options are "validation_result_identifier", "expectation_suite_name",
"data_asset_name", or the default None. Providing an invalid group_by
value will cause this method to silently fail, and return None.
Valid options are "validation_result_identifier", "expectation_suite_name",
"data_asset_name", or the default None. Providing an invalid group_by
value will cause this method to silently fail, and return None.
Returns:
A list of ExpectationSuiteValidationResult, when group_by=None
A dict of ValidationResultIdentifier keys and ExpectationValidationResults
values, when group_by="validation_result_identifier"
A dict of ValidationResultIdentifier keys and ExpectationValidationResults values,
when group_by="validation_result_identifier"
A dict of str keys and ExpectationValidationResults values, when
group_by="expectation_suite_name" or group_by="data_asset_name"
None, when group_by is something other than the options described above
Expand Down
14 changes: 7 additions & 7 deletions tests/integration/test_definitions/gcs/integration_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@
data_context_dir="tests/integration/fixtures/no_datasources/great_expectations",
backend_dependencies=[BackendDependencies.GCS],
),
# IntegrationTestFixture(
# name="how_to_host_and_share_data_docs_on_gcs",
# user_flow_script="tests/integration/docusaurus/setup/configuring_data_docs/how_to_host_and_share_data_docs_on_gcs.py",
# data_context_dir="tests/integration/fixtures/no_datasources/great_expectations",
# data_dir="tests/test_sets/taxi_yellow_tripdata_samples/first_3_files",
# backend_dependencies=[BackendDependencies.GCS],
# ),
IntegrationTestFixture(
name="how_to_host_and_share_data_docs_on_gcs",
user_flow_script="tests/integration/docusaurus/setup/configuring_data_docs/how_to_host_and_share_data_docs_on_gcs.py",
data_context_dir="tests/integration/fixtures/no_datasources/great_expectations",
data_dir="tests/test_sets/taxi_yellow_tripdata_samples/first_3_files",
backend_dependencies=[BackendDependencies.GCS],
),
IntegrationTestFixture(
name="how_to_configure_a_validation_result_store_in_gcs",
user_flow_script="tests/integration/docusaurus/setup/configuring_metadata_stores/how_to_configure_a_validation_result_store_in_gcs.py",
Expand Down

0 comments on commit 52c06f3

Please sign in to comment.