From 52c06f3a572e9ef7f3e2e06a7e4037757e707d63 Mon Sep 17 00:00:00 2001 From: William Shin Date: Thu, 18 Jan 2024 20:10:55 -0800 Subject: [PATCH] [BUGFIX] Re-enable GCS Docs Integration test (#9237) --- ci/checks/check_integration_test_gets_run.py | 1 - .../checkpoint/types/checkpoint_result.py | 10 +++++----- .../test_definitions/gcs/integration_tests.py | 14 +++++++------- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/ci/checks/check_integration_test_gets_run.py b/ci/checks/check_integration_test_gets_run.py index 1fb335b91651..37d61545a0bb 100644 --- a/ci/checks/check_integration_test_gets_run.py +++ b/ci/checks/check_integration_test_gets_run.py @@ -55,7 +55,6 @@ "tests/expectations/core/test_expect_column_mean_to_be_positive.py", "tests/integration/docusaurus/expectations/examples/column_aggregate_expectation_template.py", "tests/integration/docusaurus/expectations/examples/multicolumn_map_expectation_template.py", - "tests/integration/docusaurus/setup/configuring_data_docs/how_to_host_and_share_data_docs_on_gcs.py", ] diff --git a/great_expectations/checkpoint/types/checkpoint_result.py b/great_expectations/checkpoint/types/checkpoint_result.py index 60fea9d193fa..2241dc990734 100644 --- a/great_expectations/checkpoint/types/checkpoint_result.py +++ b/great_expectations/checkpoint/types/checkpoint_result.py @@ -201,14 +201,14 @@ def list_validation_results( Args: group_by: Specify how the ExpectationValidationResults should be grouped. - Valid options are "validation_result_identifier", "expectation_suite_name", - "data_asset_name", or the default None. Providing an invalid group_by - value will cause this method to silently fail, and return None. + Valid options are "validation_result_identifier", "expectation_suite_name", + "data_asset_name", or the default None. Providing an invalid group_by + value will cause this method to silently fail, and return None. Returns: A list of ExpectationSuiteValidationResult, when group_by=None - A dict of ValidationResultIdentifier keys and ExpectationValidationResults - values, when group_by="validation_result_identifier" + A dict of ValidationResultIdentifier keys and ExpectationValidationResults values, + when group_by="validation_result_identifier" A dict of str keys and ExpectationValidationResults values, when group_by="expectation_suite_name" or group_by="data_asset_name" None, when group_by is something other than the options described above diff --git a/tests/integration/test_definitions/gcs/integration_tests.py b/tests/integration/test_definitions/gcs/integration_tests.py index 86b709419ae3..07b7b67e8fa9 100644 --- a/tests/integration/test_definitions/gcs/integration_tests.py +++ b/tests/integration/test_definitions/gcs/integration_tests.py @@ -54,13 +54,13 @@ data_context_dir="tests/integration/fixtures/no_datasources/great_expectations", backend_dependencies=[BackendDependencies.GCS], ), - # IntegrationTestFixture( - # name="how_to_host_and_share_data_docs_on_gcs", - # user_flow_script="tests/integration/docusaurus/setup/configuring_data_docs/how_to_host_and_share_data_docs_on_gcs.py", - # data_context_dir="tests/integration/fixtures/no_datasources/great_expectations", - # data_dir="tests/test_sets/taxi_yellow_tripdata_samples/first_3_files", - # backend_dependencies=[BackendDependencies.GCS], - # ), + IntegrationTestFixture( + name="how_to_host_and_share_data_docs_on_gcs", + user_flow_script="tests/integration/docusaurus/setup/configuring_data_docs/how_to_host_and_share_data_docs_on_gcs.py", + data_context_dir="tests/integration/fixtures/no_datasources/great_expectations", + data_dir="tests/test_sets/taxi_yellow_tripdata_samples/first_3_files", + backend_dependencies=[BackendDependencies.GCS], + ), IntegrationTestFixture( name="how_to_configure_a_validation_result_store_in_gcs", user_flow_script="tests/integration/docusaurus/setup/configuring_metadata_stores/how_to_configure_a_validation_result_store_in_gcs.py",