From 3653d41f0ba3ff753ede945522e7d1c8d4e5659c Mon Sep 17 00:00:00 2001
From: Chetan Kini <chetan@superconductive.com>
Date: Wed, 28 Jun 2023 17:31:11 -0400
Subject: [PATCH] [MAINTENANCE] Add `pytest.deprecated_call` to misc usages of
 `add_datasource` in tests (#8207)

---
 tests/conftest.py                             |  9 +--
 .../test_datasource_crud.py                   | 56 ++++++++++---------
 2 files changed, 36 insertions(+), 29 deletions(-)

diff --git a/tests/conftest.py b/tests/conftest.py
index d7302c814b46..3b6491b72056 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -3600,10 +3600,11 @@ def set_side_effect(key, value):
         "great_expectations.data_context.store.datasource_store.DatasourceStore.set",
         side_effect=set_side_effect,
     ):
-        context.add_datasource(
-            "my_datasource",
-            **config,
-        )
+        with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+            context.add_datasource(
+                "my_datasource",
+                **config,
+            )
     return context
 
 
diff --git a/tests/data_context/cloud_data_context/test_datasource_crud.py b/tests/data_context/cloud_data_context/test_datasource_crud.py
index fedafd932428..6a9f921e6bb9 100644
--- a/tests/data_context/cloud_data_context/test_datasource_crud.py
+++ b/tests/data_context/cloud_data_context/test_datasource_crud.py
@@ -211,22 +211,25 @@ def test_data_context_in_cloud_mode_add_datasource(
             expected_datasource_config = datasourceConfigSchema.dump(
                 block_config_datasource_config
             )
-            stored_datasource = context.add_datasource(
-                name=datasource_name,
-                **expected_datasource_config,
-            )
+            with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+                stored_datasource = context.add_datasource(
+                    name=datasource_name,
+                    **expected_datasource_config,
+                )
         elif config_includes_name_setting == "config_includes_name":
-            stored_datasource = context.add_datasource(
-                **datasource_config_with_name.to_dict()
-            )
+            with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+                stored_datasource = context.add_datasource(
+                    **datasource_config_with_name.to_dict()
+                )
         elif (
             config_includes_name_setting
             == "name_supplied_separately_and_included_in_config"
         ):
-            stored_datasource = context.add_datasource(
-                name=datasource_name,
-                **datasource_config_with_name.to_dict(),
-            )
+            with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+                stored_datasource = context.add_datasource(
+                    name=datasource_name,
+                    **datasource_config_with_name.to_dict(),
+                )
         else:
             raise ValueError(
                 "Invalid value provided for 'config_includes_name_setting'"
@@ -323,25 +326,28 @@ def test_cloud_data_context_add_datasource(
             expected_datasource_config = datasourceConfigSchema.dump(
                 block_config_datasource_config
             )
-            stored_datasource = context.add_datasource(
-                name=datasource_name,
-                **expected_datasource_config,
-                save_changes=True,
-            )
+            with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+                stored_datasource = context.add_datasource(
+                    name=datasource_name,
+                    **expected_datasource_config,
+                    save_changes=True,
+                )
         elif config_includes_name_setting == "config_includes_name":
-            stored_datasource = context.add_datasource(
-                **datasource_config_with_name.to_dict(),
-                save_changes=True,
-            )
+            with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+                stored_datasource = context.add_datasource(
+                    **datasource_config_with_name.to_dict(),
+                    save_changes=True,
+                )
         elif (
             config_includes_name_setting
             == "name_supplied_separately_and_included_in_config"
         ):
-            stored_datasource = context.add_datasource(
-                name=datasource_name,
-                **datasource_config_with_name.to_dict(),
-                save_changes=True,
-            )
+            with pytest.deprecated_call():  # non-FDS datasources discouraged in Cloud
+                stored_datasource = context.add_datasource(
+                    name=datasource_name,
+                    **datasource_config_with_name.to_dict(),
+                    save_changes=True,
+                )
         else:
             raise ValueError(
                 "Invalid value provided for 'config_includes_name_setting'"