From 71a24b3e50c62986b089cf2867d8e94f2e12f936 Mon Sep 17 00:00:00 2001 From: Zain Patel Date: Tue, 7 Apr 2020 18:49:07 +0100 Subject: [PATCH 1/3] Remove profile docstring --- great_expectations/cli/datasource.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/great_expectations/cli/datasource.py b/great_expectations/cli/datasource.py index 86ac572283b5..baf59539cb6c 100644 --- a/great_expectations/cli/datasource.py +++ b/great_expectations/cli/datasource.py @@ -155,14 +155,6 @@ def datasource_profile(datasource, generator_name, data_assets, profile_all_data if the number of data assets in the datasource exceeds the internally defined limit. If it does, it will prompt the user to either specify the list of data assets to profile or to profile all. If the limit is not exceeded, the profiler will profile all data assets in the datasource. - - :param datasource: name of the datasource to profile - :param data_assets: if this comma-separated list of data asset names is provided, only the specified data assets will be profiled - :param profile_all_data_assets: if provided, all data assets will be profiled - :param directory: - :param view: Open the docs in a browser - :param additional_batch_kwargs: Additional keyword arguments to be provided to get_batch when loading the data asset. - :return: """ cli_message("Warning - this is a BETA feature.") try: From 55a62d9d08760dc1cfea42d8e2d1c09699982a76 Mon Sep 17 00:00:00 2001 From: Zain Patel <30357972+mzjp2@users.noreply.github.com> Date: Wed, 8 Apr 2020 00:17:47 +0100 Subject: [PATCH 2/3] Fix 0.9.8 changelog entries --- docs/changelog/changelog.rst | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/changelog/changelog.rst b/docs/changelog/changelog.rst index cc7cd8a2b3af..4a6b32bdd0df 100644 --- a/docs/changelog/changelog.rst +++ b/docs/changelog/changelog.rst @@ -18,10 +18,8 @@ develop * Remove the "project new" option from the command line (since it is not implemented; users can only run "init" to create a new project). * Update type detection for bigquery based on driver changes in pybigquery driver 0.4.14. Added a warning for users who are running an older pybigquery driver * added execution tests to the NotebookRenderer to mitigate codegen risks -* Add option "persist", true by default, for SparkDFDataset to persist the DataFrame it is passed. This addresses #1133 -in a deeper way (thanks @tejsvirai for the robust debugging support and reproduction on spark). - - Disabling this option should *only* be done if the user has *already* externally persisted the DataFrame, or if the -dataset is too large to persist but *computations are guaranteed to be stable across jobs*. +* Add option "persist", true by default, for SparkDFDataset to persist the DataFrame it is passed. This addresses #1133 in a deeper way (thanks @tejsvirai for the robust debugging support and reproduction on spark). + Note: Disabling this option should *only* be done if the user has *already* externally persisted the DataFrame, or if the dataset is too large to persist but *computations are guaranteed to be stable across jobs*. * Enable passing dataset kwargs through datasource via dataset_options batch_kwarg. * Fix AttributeError when validating expectations from a JSON file * Data Docs: fix bug that was causing erratic scrolling behavior when table of contents contains many columns From 31ca217fef33529a35dc06d03a985644ba6a3cf1 Mon Sep 17 00:00:00 2001 From: Zain Patel <30357972+mzjp2@users.noreply.github.com> Date: Wed, 8 Apr 2020 00:23:39 +0100 Subject: [PATCH 3/3] Fix other changelog entries --- docs/changelog/changelog.rst | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/docs/changelog/changelog.rst b/docs/changelog/changelog.rst index 4a6b32bdd0df..0d36551b1798 100644 --- a/docs/changelog/changelog.rst +++ b/docs/changelog/changelog.rst @@ -19,7 +19,7 @@ develop * Update type detection for bigquery based on driver changes in pybigquery driver 0.4.14. Added a warning for users who are running an older pybigquery driver * added execution tests to the NotebookRenderer to mitigate codegen risks * Add option "persist", true by default, for SparkDFDataset to persist the DataFrame it is passed. This addresses #1133 in a deeper way (thanks @tejsvirai for the robust debugging support and reproduction on spark). - Note: Disabling this option should *only* be done if the user has *already* externally persisted the DataFrame, or if the dataset is too large to persist but *computations are guaranteed to be stable across jobs*. + * Disabling this option should *only* be done if the user has *already* externally persisted the DataFrame, or if the dataset is too large to persist but *computations are guaranteed to be stable across jobs*. * Enable passing dataset kwargs through datasource via dataset_options batch_kwarg. * Fix AttributeError when validating expectations from a JSON file * Data Docs: fix bug that was causing erratic scrolling behavior when table of contents contains many columns @@ -28,10 +28,8 @@ develop 0.9.7 ----------------- * Update marshmallow dependency to >3. NOTE: as of this release, you MUST use marshamllow >3.0, which REQUIRES python 3. (`#1187 `_) @jcampbell - - Schema checking is now stricter for expectation suites, and data_asset_name must not be present as a top-level - key in expectation suite json. It is safe to remove. - - Similarly, datasource configuration must now adhere strictly to the required schema, including having any - required credentials stored in the "credentials" dictionary. + * Schema checking is now stricter for expectation suites, and data_asset_name must not be present as a top-level key in expectation suite json. It is safe to remove. + * Similarly, datasource configuration must now adhere strictly to the required schema, including having any required credentials stored in the "credentials" dictionary. * New beta CLI command: `tap new` that generates an executable python file to expedite deployments. (`#1193 `_) @Aylr * bugfix in TableBatchKwargsGenerator docs * Added feature maturity in README (`#1203 `_) @kyleaton @@ -75,8 +73,8 @@ develop * Add support for transient table creation in snowflake (#1012) * Improve path support in TupleStoreBackend for better cross-platform compatibility * New features on `ExpecatationSuite` - - `.add_citation()` - - `get_citations()` + - `.add_citation()` + - `get_citations()` * `SampleExpectationsDatasetProfiler` now leaves a citation containing the original batch kwargs * `great_expectations suite edit` now uses batch_kwargs from citations if they exist * Bugfix :: suite edit notebooks no longer blow away the existing suite while loading a batch of data