Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite edit CLI command fails with "KeyError: 'column'" #1194

Closed
eugmandel opened this issue Mar 17, 2020 · 2 comments
Closed

suite edit CLI command fails with "KeyError: 'column'" #1194

eugmandel opened this issue Mar 17, 2020 · 2 comments

Comments

@eugmandel
Copy link
Contributor

User report:

I’m trying out Great Expectations right now and running into an issue where I can no longer run great_expectations suite edit to change any of my expectations due to the following error:

File "/Users/blake/.virtualenvs/great-expectations/lib/python3.7/site-packages/great_expectations/render/renderer/notebook_renderer.py", line 29, in _get_expectations_by_column
col = exp["kwargs"]["column"]
KeyError: 'column'

I can still run great_expectations docs build and a validation script with no problems. It’s just the editing that’s not working. Any ideas?

@eugmandel
Copy link
Contributor Author

This is a bug in the notebook_renderer that generated the jupyter notebook to be used for editing an expectation suite.

eugmandel added a commit that referenced this issue Mar 17, 2020
@eugmandel
Copy link
Contributor Author

Some expectations do not have "table" in their name and also don't have "column" in their kwargs (e.g., expect_multicolumn_values_to_be_unique).

The fix was swapping the if and the else.

@Aylr Aylr closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants