Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updating to reflect current Expectation dev state #3348

Merged

Conversation

spencerhardwick
Copy link
Contributor

These changes reflect the current state of Expectation implementations in v3

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Updated the Expectation Implementations by Backend table on the v3 docs to reflect work completed by Superconductive Product Engineering last development cycle.

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • I have made corresponding changes to the documentation
  • I have made sure that nothing is broken.

Thank you for submitting!

These changes reflect the current state of Expectation implementations in v3
@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: 0a7e7fd

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61320e031922b1000718e569

😎 Browse the preview: https://deploy-preview-3348--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

@spencerhardwick spencerhardwick enabled auto-merge (squash) September 3, 2021 00:44
Copy link
Member

@cdkini cdkini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going off of the assumption that this view is indeed correct, I'm happy to sign off :)

Thanks for all the hard work with this and for making our docs that much nicer 🎉

@bhcastleton
Copy link
Contributor

Do we want to say something like “Updated as of September 2, 2021” ?? If not, then I assume we'll keep it up-to-date until the gallery comes out.

@spencerhardwick
Copy link
Contributor Author

Going off of the assumption that this view is indeed correct, I'm happy to sign off :)

Thanks for all the hard work with this and for making our docs that much nicer 🎉

Thanks Chetan!

@kyleaton
Copy link
Member

kyleaton commented Sep 3, 2021

@cla-bot check

@spencerhardwick spencerhardwick merged commit 8f79384 into develop Sep 3, 2021
@spencerhardwick spencerhardwick deleted the spencerhardwick-expectationimplementationupdate-1 branch September 3, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants