Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Ensure proper exit code for dependency graph script #3839

Merged

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Dec 12, 2021

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • The lack of an error code would allow the CI/CD stage to pass (even if pytest failed)

Screen Shot 2021-12-13 at 9 46 57 AM

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Dec 12, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: a14e20a

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61b765ba15ab0c0008328875

😎 Browse the preview: https://deploy-preview-3839--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

…tions into bugfix/ensure-proper-exit-code-for-dependency-graph-script
@cdkini cdkini force-pushed the bugfix/ensure-proper-exit-code-for-dependency-graph-script branch from 73404cc to 9f86996 Compare December 13, 2021 14:26
@cdkini cdkini self-assigned this Dec 13, 2021
Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdkini cdkini enabled auto-merge (squash) December 13, 2021 15:24
@cdkini cdkini merged commit d6150b0 into develop Dec 13, 2021
@cdkini cdkini deleted the bugfix/ensure-proper-exit-code-for-dependency-graph-script branch December 13, 2021 15:25
Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants