Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fixes tutorial link in reference architecture prereqs component #4360

Merged
merged 5 commits into from Mar 9, 2022

Conversation

austiezr
Copy link
Contributor

@austiezr austiezr commented Mar 8, 2022

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Changes prereqs for deployment patterns to point to the new tutorial

After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Mar 8, 2022

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: d6bf6b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/62291693eb8945000881aacd

😎 Browse the preview: https://deploy-preview-4360--niobium-lead-7998.netlify.app

@austiezr austiezr changed the title [DOCS] Fixes tutorial link in deployment pattern prereqs component [DOCS] Fixes tutorial link in reference architecture prereqs component Mar 8, 2022
@austiezr austiezr enabled auto-merge (squash) March 8, 2022 21:33
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated links look good to me.

@austiezr austiezr merged commit 2812c3b into develop Mar 9, 2022
@austiezr austiezr deleted the 4188 branch March 9, 2022 21:06
Shinnnyshinshin pushed a commit that referenced this pull request Mar 10, 2022
* develop:
  [MAINTENANCE] Setting stage for removal of `--no-postgresql` and `--no-spark` flags from `pytest` (#4309)
  [MAINTENANCE] Update great_expectations_contrib CLI tool to use existing diagnostic classes (#4316)
  Fixed tutorial link in prereqs component (#4360)
  [HACKATHON] ExpectColumnAverageToBeWithinRangeOfGivenPoint (#4356)
  [FEATURE] Enable expect_column_min/_max_to_be_between expectations to be self-initializing (#4363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No "next" button in tutorial intro
2 participants