New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HACKATHON] ColumnValuesLinestringKMDistanceBetween #4647
[HACKATHON] ColumnValuesLinestringKMDistanceBetween #4647
Conversation
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
…values_to_be_line_between
…ps://github.com/luismdiaz01/great_expectations into feature/expect_column_values_to_be_line_between
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @luismdiaz01 ! Thanks for this submission; excited to see this functionality!
It looks like we're hitting a couple issues.
I'm getting a linting flag that can be resolved with black; check our linting docs here.
We also want to be sure to capture any dependencies as requirements in our library_metadata
I'm also hitting an error when running your tests that seems like the data isn't being parsed as linestrings when read into geopandas; there may be something to investigate there.
…values_to_be_line_between
…ps://github.com/luismdiaz01/great_expectations into feature/expect_column_values_to_be_line_between
Thanks for the comments @austiezr ! I fixed the issues you mentioned but am having trouble the tests that I made. I troubleshooted with some of the other geospatial expectations and saw that they also wouldn't pass the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @luismdiaz01 ! One minor fix.
...xpectations_experimental/expectations/expect_column_values_to_be_line_km_distance_between.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @luismdiaz01 and be sure this PR is linked in your DevPost submission as well. 🚀
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123
).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!