[BUGFIX] For DataAssistants, added try-except for Notebook tests #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 13, 2022 15:23
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Shinnnyshinshin
commented
May 15, 2022
Comment on lines
+715
to
+718
| "#import shutil, os\n", | ||
| "#shutil.rmtree(\"great_expectations/expectations/tmp\")\n", | ||
| "#os.remove(\"great_expectations/expectations/.ge_store_backend_id\")\n", | ||
| "#os.remove(\"great_expectations/expectations/taxi_data_suite.json\")" |
There was a problem hiding this comment.
Turns out this was the cause of the bug 😓
Shinnnyshinshin
changed the title
cdkini
requested changes
May 15, 2022
Comment on lines
49
to
59
| try: | ||
| shutil.rmtree(os.path.join(base_dir, "great_expectations/expectations/tmp")) | ||
| os.remove( | ||
| os.path.join( | ||
| base_dir, "great_expectations/expectations/.ge_store_backend_id" | ||
| ) | ||
| ) | ||
| except FileNotFoundError: | ||
| # This just means the files were already deleted by running the optional last cell in the notebook. | ||
| # Therefore we allow the test to pass. | ||
| pass |
There was a problem hiding this comment.
I think this file deletion should occur nested under the finally block - if anything goes wrong earlier on in the test, these files will not be deleted.
Also, do we need to write the results to a temp notebook? What are your thoughts on devs just running the original notebook to debug?
Finally, could we please log when we hit the FileNotFoundError so that comment you wrote is presented in stdout?
There was a problem hiding this comment.
Great suggestions.I thought the point on adding the FileNotFoundError to the log was fantastic, so my most recent commit has that change. I have some questions about what you had in mind for finally block and was wondering if you had time to discuss tomorrow?
Comment on lines
99
to
103
| try: | ||
| shutil.rmtree(os.path.join(base_dir, "great_expectations/expectations/tmp")) | ||
| os.remove( | ||
| os.path.join( | ||
| base_dir, "great_expectations/expectations/.ge_store_backend_id" |
There was a problem hiding this comment.
thank you for helping me see the light ⚡ 🌞
cdkini
approved these changes
May 16, 2022
Shinnnyshinshin
deleted the
bugfix/example-notebook-use-new-plotting-methods
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
May 17, 2022
…ing-expectations * develop: [FEATURE] `DataAssistant` plotting for non-sequential batches (#5126) Move upper bound on sqlalchemy to <2.0.0. (#5140) [FEATURE] Enable self-initializing `ExpectColumnValueLengthsToBeBetween` (#4985) Use `external_sqldialect` mark to skip tests during lightweight packaging test run. (#5139) [FEATURE] For OnboardingDataAssistant: Implement a TABLE Domain level rule to output "expect_table_columns_to_match_set" (#5137) [FEATURE] Giving the "expect_table_columns_to_match_set" Expectation Self-Initializing Capabilities. (#5136) [FEATURE] OnboardingDataAssistant: Introduce MeanTableColumnsSetMatchMultiBatchParameterBuilder (to enable expect_table_columns_to_match_set) (#5135) [FEATURE] Categorical Rule is added to OnboardingDataAssistant (#5134) CategoricalColumnDomainBuilder needs to accept limit_mode with dictionary type (#5127) add trino dialect (#5085) [BUGFIX] For DataAssistants, added try-except for Notebook tests (#5124) [MAINTENANCE] Sqlite specific tests for splitting and sampling (#5119) [FEATURE] DateTime Rule for OnboardingDataAssistant (#5121) [FEATURE] Onboarding DataAssistant: Numeric Rules and Relevant Metrics (#5120) [BUGFIX] Update `DataAssistant` notebook for new plotting API (#5118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What went wrong?
RBPandDataAssistantNotebook that deletes files that are usually generated by the notebook (like ExpectationSuites, and.ge_cloud_idfiles). This cell is normally commented out, but wasn't in the previous PR 😅test_run_profiler_notebook.pytests, the is a part of the test that tries to delete these same files.. since they were deleted by running the Notebook, the test was giving aFileNotFoundError.What does this PR fix?
DataAssistantNotebook that was causing tests to failtests/integration/profiling/rule_based_profilers/test_run_profiler_notebook.pyThank you for submitting!