[MAINTENANCE] Test serialization of text, table, and bulleted list rendered_content in ExpectationValidationResult
#5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…mplated-renderers-in-validation-result
👇 Click on the image for a new way to code review
Legend |
added 2 commits
July 5, 2022 10:25
…ers-in-validation-result' of github.com:great-expectations/great_expectations into maintenance/GREAT-911/GREAT-962/return-templated-renderers-in-validation-result
NathanFarmer
changed the title
NathanFarmer
changed the title
rendered_content in ExpectationValidationResult
cdkini
approved these changes
Jul 5, 2022
Comment on lines
+20
to
+24
| pytest.param( | ||
| ExpectationConfiguration( | ||
| expectation_type="expect_table_row_count_to_equal", | ||
| kwargs={"value": 3}, | ||
| ), |
There was a problem hiding this comment.
Could we give each of these params an id or name so we're able to access them with pytest -k?
There was a problem hiding this comment.
I was about to write the same thing 🙇
There was a problem hiding this comment.
I added an id to each of the test cases and confirmed it works with pytest -k ✅
NathanFarmer
deleted the
maintenance/GREAT-911/GREAT-962/return-templated-renderers-in-validation-result
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jul 5, 2022
…eature/GREAT-954/data-assistant-logic-migration * feature/GREAT-1009/remaining-migration-for-init: save_project_config_to_file docstrings and type hints refactor: remove datasource_name as arg to update_datasource (#5440) [MAINTENANCE] Test serialization of text, table, and bulleted list `rendered_content` in `ExpectationValidationResult` (#5438) DOC-322 (#5326) [FEATURE] Refactor Splitter Testing Modules so as to Make them More General and Add Unit and Integration Tests for "split_on_whole_table" and "split_on_column_value" on SQLite and All Supported Major SQL Backends (#5430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Definition of Done