New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Ensure that validation operators are omitted from Cloud variables payload #5510
[MAINTENANCE] Ensure that validation operators are omitted from Cloud variables payload #5510
Conversation
…_expectations into maintenance/great-889/clean-up-cloud-payload-for-variables
…_expectations into maintenance/great-889/clean-up-cloud-payload-for-variables
…_expectations into maintenance/great-889/clean-up-cloud-payload-for-variables
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
if attr in payload: | ||
payload.pop(attr) | ||
logger.debug( | ||
f"Removed {attr} from DataContextConfig while serializing to JSON" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also do it like this.
Not necessarily better, feel free to leave it as you have it.
Too bad we can't use the :=
operator here 😢
if attr in payload: | |
payload.pop(attr) | |
logger.debug( | |
f"Removed {attr} from DataContextConfig while serializing to JSON" | |
) | |
removed = payload.pop(attr, None) | |
if removed: | |
logger.debug( | |
f"Removed {attr} from DataContextConfig while serializing to JSON" | |
) |
…oad-for-variables
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.