Skip to content

Conversation

@sp1thas
Copy link
Contributor

@sp1thas sp1thas commented Jul 24, 2022

Changes proposed in this pull request:

  • Add experimental expectation CRC32 hash validation

This PR introduces expect_column_values_to_be_valid_crc32, this expectation validates that column values are valid CRC32 hashes.

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Jul 24, 2022

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 4ec4967
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62ddb5686c92c10009ea1766

@austiezr austiezr added community devrel This item is being addressed by the Developer Relations Team labels Aug 3, 2022
Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sp1thas ! 🚀

@austiezr austiezr enabled auto-merge (squash) August 3, 2022 14:39
@austiezr austiezr merged commit 52e7144 into great-expectations:develop Aug 3, 2022
@sp1thas sp1thas deleted the feat/valid-crc32 branch August 3, 2022 16:42
Shinnnyshinshin pushed a commit that referenced this pull request Aug 5, 2022
…etric-change

* develop: (30 commits)
  Add mysql client to Dockerfile.tests (#5681)
  [DOCS]added guide how to use great expectations with aws glue (#5536)
  [MAINTENANCE] Assign `resource_type` in `InlineStoreBackend` constructor (#5671)
  [RELEASE] 0.15.17 (#5675)
  fix: patch issue with 'id' vs 'id_' (#5677)
  Tidying up  the texts and config in gen; bump ops (#5678)
  [MAINTENANCE] data_context initial type checking (#5662)
  [FEATURE]Enable showing expectation suite by domain and by expectation_type -- from DataAssistantResult (#5673)
  [MAINTENANCE] Ensure that `id_` fields in Marshmallow schema serialize as `id` (#5660)
  [MAINTENANCE] Improve DateTime Conversion Candling in Comparison Metrics & Expectations and Provide a Clean Object Model for Metrics Computation Bundling (#5656)
  [MAINTENANCE] Only run Cloud E2E tests in primary pipeline
  Refactor docker test CI steps into jobs. (#5665)
  [MAINTENANCE] move tool config to pyproject.toml (#5649)
  add expectation for crc32 (#5580)
  Quick bug fix to all profile numeric column bounds expectations (#5651)
  Don't include 'test-pipeline' in extras_require dict (#5659)
  [ANALYTICS] add new invoke tasks to `tasks.py` and create new file `usage_stats_utils.py` (#5593)
  [MAINTENANCE] Introduce running tests in docker on our Azure CI pipeline. (#5646)
  [MAINTENANCE] Add E2E Cloud test for `DataContext.add_checkpoint()` (#5653)
  Make comparisons of aggregate values date aware (#5642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community devrel This item is being addressed by the Developer Relations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants