[MAINTENANCE] Clean up xfails in preparation for 0.15.20 release #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
cdkini
commented
Aug 25, 2022
| @@ -252,7 +251,7 @@ def _closure(context: DataContext) -> Tuple[Validator, str]: | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail( | |||
| reason="GX Cloud E2E tests are currently failing due to a schema issue with DataContextVariables; xfailing for purposes of the 0.15.20 release", | |||
| reason="GX Cloud E2E tests are currently failing due to an id issue with ExpectationSuites; xfailing for purposes of the 0.15.20 release", | |||
There was a problem hiding this comment.
Separate issue I'll need to look into
Kilo59
approved these changes
Aug 25, 2022
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 25, 2022
…ssed-in-as-batchspec-passthrough-spark * develop: [MAINTENANCE] Add entries to release schedule [MAINTENANCE] Unit tests to ensure coverage over `Datasource` caching in `DataContext` (#5839) [MAINTENANCE] Unit Tests Pipeline step (#5838) [RELEASE] 0.15.20 (#5831) [MAINTENANCE] Add back xfails for E2E Cloud tests that fail on env var retrieval in Docker (#5837) [MAINTENANCE] Clean up xfails in preparation for 0.15.20 release (#5835)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 26, 2022
…r-usage-stats-opt * develop: (337 commits) [MAINTENANCE] Finer-grain type exclude (#5848) remove pyparsing pin for <3.0 (#5849) [MAINTENANCE] add --ignore-suppress and --ignore-only-for to build_gallery.py with bugfixes (#5802) [MAINTENANCE] `datasource`, `data_context`, `core` typing, lint fixes (#5824) [MAINTENANCE] Mark miscellaneous tests with `@pytest.mark.unit` (#5846) [MAINTENANCE] Add additional unit tests around `Datasource` caching (#5844) [MAINTENANCE] Properly label DataAssistant tests with @pytest.mark.integration [DOCS] DOC-364 how to configure a spark datasource (#5840) [MAINTENANCE] Add entries to release schedule [MAINTENANCE] Unit tests to ensure coverage over `Datasource` caching in `DataContext` (#5839) [MAINTENANCE] Unit Tests Pipeline step (#5838) [RELEASE] 0.15.20 (#5831) [MAINTENANCE] Add back xfails for E2E Cloud tests that fail on env var retrieval in Docker (#5837) [MAINTENANCE] Clean up xfails in preparation for 0.15.20 release (#5835) [MAINTENANCE] xfail Cloud E2E tests due to schema issue with `DataContextVariables` (#5828) [FEATURE] DataAssistants Example Notebook - Pandas (#5820) [MAINTENANCE] Update `list_` methods on `DataContext` to emit names along with object ids (#5826) Bugfix/snowflake temp table schema name (#5814) [FEATURE] Better error for missing expectation (#5750) [Maintenance] Clean up build_parameter_container_for_variables (#5823) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
strict, we need to modify these tests before the release.Definition of Done
Please delete options that are not relevant.