Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomTypes Doc Updates #635

Merged
merged 7 commits into from Aug 19, 2019
Merged

CustomTypes Doc Updates #635

merged 7 commits into from Aug 19, 2019

Conversation

jcampbell
Copy link
Member

  • also adds a missing test for interactive evaluation.

@coveralls
Copy link

coveralls commented Aug 19, 2019 •
edited

Coverage Status

Coverage increased (+0.01%) to 81.322% when pulling db45460 on feature/custom_types into f7a7848 on develop.

abegong
abegong approved these changes Aug 19, 2019
View reviewed changes
docs/core_concepts/datasource.rst
@@ -23,6 +21,9 @@ a SqlAlchemyDataset corresponding to that batch of data and ready for validation
Since opinionated DAG managers such as airflow, dbt, prefect.io, dagster can also act as datasources
and/or generators for a more generic datasource.

When adding custom expectations by subclassing an existing DataAsset type, use the data_asset_type parameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: data_asset.type, right? As opposed to data_asset_type...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is data_asset_type:

datasources:
  my_datasource:
    class_name: PandasDatasource
    data_asset_type:
      module_name: custom_pandas_datasource
      class_name: CustomPandasDatasource
    generators:
      default:
        type: subdir_reader
        base_directory: /data

roblim
roblim approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@roblim roblim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcampbell jcampbell merged commit e1de421 into develop Aug 19, 2019
@jcampbell jcampbell deleted the feature/custom_types branch August 19, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugmandel eugmandel eugmandel approved these changes

@abegong abegong abegong approved these changes

@roblim roblim roblim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcampbell @coveralls @eugmandel @abegong @roblim