Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove batching_regex as arg to FilePathDataConnectors #9715

Closed
wants to merge 36 commits into from
Closed

[FEATURE] Remove batching_regex as arg to FilePathDataConnectors #9715

wants to merge 36 commits into from

Commits on Apr 4, 2024

  1. move file function into class

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c1163c4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into f/v1-274/refactor_loose_functions_to_class

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    fe8839a View commit details
    Browse the repository at this point in the history

  3. replace floating funcs with a top level override

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    18aacc3 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary fork

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9320f8c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into f/v1-274/refactor_loose_functions_to_class

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    349741e View commit details
    Browse the repository at this point in the history

  6. Add batching_regex to batch config and plugin to FilePathDataconnector

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    54e5eb7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into f/v1-274/add_batching_regex_to_batch_request

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9fa22da View commit details
    Browse the repository at this point in the history

  8. cleanup dead code and add test

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    530edf2 View commit details
    Browse the repository at this point in the history

  9. improve test

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5cb3ff7 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' into f/v1-274/add_batching_regex_to_batch_request

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a547fb2 View commit details
    Browse the repository at this point in the history

  11. update type file

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a6ed68f View commit details
    Browse the repository at this point in the history

  12. update type to be 3.8 compatible

    @joshua-stauffer
    joshua-stauffer committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    73ea68c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. update test to include batching_regex

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4fcbaad View commit details
    Browse the repository at this point in the history

  2. parametrize test

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e1be534 View commit details
    Browse the repository at this point in the history

  3. add batching_regex to LegacyBatchDefinition

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    cfc395d View commit details
    Browse the repository at this point in the history

  4. update test

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    39de135 View commit details
    Browse the repository at this point in the history

  5. update type

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4a6db0e View commit details
    Browse the repository at this point in the history

  6. update type of batching_regex

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fcd1a89 View commit details
    Browse the repository at this point in the history

  7. make re.Pattern serializable and test

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7fc8473 View commit details
    Browse the repository at this point in the history

  8. _generate_batch_spec_parameters_from_batch_definition uses batching_r… 

    …egex from LegacyBatchDefinition
    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1de0b4d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into f/v1-274/add_batching_regex_to_legacy_bat… 

    …ch_definition
    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ab7661f View commit details
    Browse the repository at this point in the history

  10. remove regex as param, add error

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c70ba66 View commit details
    Browse the repository at this point in the history

  11. remove batching_regex as param from all FilePathDataConnector impleme… 

    …ntations
    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    22d13bf View commit details
    Browse the repository at this point in the history

  12. update tests

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4abf3c2 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'develop' into f/v1-274/add_batching_regex_to_legacy_bat… 

    …ch_definition
    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    94c65f5 View commit details
    Browse the repository at this point in the history

  14. update datasource _build_data_connector methods

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ebac2da View commit details
    Browse the repository at this point in the history

  15. update more calls to _build_data_connector

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0f5b4a8 View commit details
    Browse the repository at this point in the history

  16. wip updating tests

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c41a024 View commit details
    Browse the repository at this point in the history

  17. allow DataConnector to continue using init batching_regex

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    dfe3d41 View commit details
    Browse the repository at this point in the history

  18. update test

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    cc8d958 View commit details
    Browse the repository at this point in the history

  19. fix another test

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8982b1e View commit details
    Browse the repository at this point in the history

  20. Merge branch 'f/v1-274/add_batching_regex_to_legacy_batch_definition_… 

    …only' into f/v1-274/add_batching_regex_to_legacy_batch_definition
    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    69e01f3 View commit details
    Browse the repository at this point in the history

  21. update test

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e8f0c0a View commit details
    Browse the repository at this point in the history

  22. close brackets

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c47f24f View commit details
    Browse the repository at this point in the history

  23. update more tests

    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    05de6ff View commit details
    Browse the repository at this point in the history

  24. Merge branch 'develop' into f/v1-274/add_batching_regex_to_legacy_bat… 

    …ch_definition
    @joshua-stauffer
    joshua-stauffer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b0358bd View commit details
    Browse the repository at this point in the history