Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/pmod: add nmigen pmod example #112

Conversation

TomKeddie
Copy link
Contributor

As per #109

@ktemkin
Copy link
Contributor

ktemkin commented May 3, 2021

Example code in general is always good, but I'm not sure this is the right place for this.

Questions:

  • Does this belong in the LUNA repository itself? This more seems like an example of using nmigen, rather than an example of anything LUNA-specific. (See the hw_features for LUNA-specific examples.)
  • Is this a good example of PMOD use, if we do decide yes on the former? I'd prefer examples to be relatively self-contained and to have walkthrough-level documentation (like they would if they were in a minimal tutorial).

@TomKeddie
Copy link
Contributor Author

@ktemkin thanks, I agree but I do think an example showing the pmod connectors in use would be good in luna. Perhaps an extension of blink that puts the led output through a cable looping pmod A to pmod B?

Alternately I'd be happy to add documentation. As per #72 the examples need a structure within which to document them.

@straithe
Copy link
Member

Hi, Tom. Thank you for your PR! I'm working on updating the LUNA documentation so there is space for this example. It might be a while yet. I'll ping you as soon as a structure is in place for examples.

@TomKeddie
Copy link
Contributor Author

@straithe cool, I'm still around. I passed my luna on to some who had a more immediate need but I'm fine with getting this example into shape as needed. Thanks for your hard work.

@straithe straithe added the documentation documentation improvement or addition label Nov 4, 2021
@miek miek self-assigned this Nov 12, 2021
@miek
Copy link
Member

miek commented Nov 3, 2023

I'm gonna go ahead and close this as we're moving board-specific components out of this repo. We'll integrate something like this into an example or tutorial as we flesh out the Cynthion documentation. Thanks!

@miek miek closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation improvement or addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants