Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/heat assets costs #189

Merged
merged 8 commits into from
Jan 4, 2021
Merged

Fix/heat assets costs #189

merged 8 commits into from
Jan 4, 2021

Conversation

MaGering
Copy link
Collaborator

With this PR the cost parameters of the heat assets are adapted since the parameter specific_costs_om of the heat pump was wrong. Further the parameters of an air to water heat pump are added to the template in energyConsumption.csv

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code
  • ❌ Update the CHANGELOG.md (let's start this after the first release)
  • Apply black (black . --exclude docs/)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@Piranias
Copy link
Contributor

Piranias commented Jan 4, 2021

unfortunately these changes stand in conflict with the new file structur (#190 ), where the PARAMETERS_mvs_input file will be deleted. Can the changes be applied to the new file structure directly?

@MaGering MaGering changed the base branch from dev to new_file_structure January 4, 2021 09:44
Copy link
Contributor

@Piranias Piranias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das einzige ist, dass es vielleicht sinnvoll wäre sich eine einheitliche Zitierweise im Read the docs zu überlegen. Aber das kann auch später für alles zusammen noch geändert werden..

@MaGering
Copy link
Collaborator Author

MaGering commented Jan 4, 2021

das einzige ist, dass es vielleicht sinnvoll wäre sich eine einheitliche Zitierweise im Read the docs zu überlegen. Aber das kann auch später für alles zusammen noch geändert werden..

That's a good point! This will have to be done solving issue #154

@MaGering MaGering merged commit 149b0bd into new_file_structure Jan 4, 2021
@MaGering MaGering deleted the fix/heat_assets_costs branch January 4, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants