Permalink
Browse files

use RRAS only if environment variable XORP_USE_RRAS is set

use RRAS only if environment variable XORP_USE_RRAS is set

 I.e. not-developers can be work with XORP on Windows comps with RRAS component
( RRAS very often not configure as _router_ ,
usual it simply installed by other MS software )

 Who want use feature "xorprtm dll" / "RTMv2"
-- simply set XORP_USE_RRAS=y

Signed-off-by: Victor Miasnikov <vvm@tut.by>
  • Loading branch information...
1 parent ad8f554 commit d4b1ef1d90fa2a5046098e21000eb33703121bee Victor Miasnikov committed with Mar 16, 2012
Showing with 22 additions and 0 deletions.
  1. +22 −0 xorp/fea/data_plane/control_socket/windows_rras_support.cc
@@ -50,6 +50,28 @@ WinSupport::is_rras_running()
bool is_installed = false;
bool is_running = false;
+ //
+ // If environment variable XORP_USE_RRAS is not set ,
+ // then disable feature "xorprtm dll" / "RTMv2"
+ //
+ // I.e. not-developers can be work with XORP on Windows comps with RRAS component
+ // ( RRAS very often not configure as _router_ , usual it simply installed by other MS software )
+ //
+ // Who want use feature "xorprtm dll" / "RTMv2" -- simply set XORP_USE_RRAS=y
+ //
+ // See:
+ //
+ // http://mailman.icsi.berkeley.edu/pipermail/xorp-hackers/2012-March/003315.html
+ // http://mailman.icsi.berkeley.edu/pipermail/xorp-hackers/2012-March/003317.html
+ //
+ //
+ // TODO: XXX: do feature "xorprtm dll" / "RTMv2" worked stable
+ //
+ const char* pf = getenv("XORP_USE_RRAS");
+ if (pf == NULL) {
+ return (is_running && is_installed);
+ }
+
SC_HANDLE h_scm = OpenSCManager(NULL, NULL, GENERIC_READ);
if (h_scm != NULL) {
SC_HANDLE h_rras = OpenService(h_scm, RRAS_SERVICE_NAME, GENERIC_READ);

0 comments on commit d4b1ef1

Please sign in to comment.