Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused field _eventloop in xrl_cli_node #112

Open
wants to merge 3 commits into
base: master
from

Conversation

@hsn10
Copy link
Contributor

hsn10 commented Dec 23, 2013

clang 3.3 do not likes this

hsn10 added 3 commits Dec 23, 2013
remove only private field, keep argument event loop in constructor
@greearb
Copy link
Owner

greearb commented Dec 23, 2013

Please merge these changes into a single patch, I do not want to merge needless reverts upstream.

@hsn10
Copy link
Contributor Author

hsn10 commented Dec 23, 2013

i am leaving it as it is, there is about 15 changes to go, i do not have infinite time in hand.

@greearb
Copy link
Owner

greearb commented Dec 23, 2013

On 12/23/2013 01:37 PM, Radim Kolar wrote:

i am leaving it as it is, there is about 15 changes to go, i do not have infinite time in hand.


Reply to this email directly or view it on GitHub #112 (comment).

Check out 'stg', it makes merging patches and editing commit messages
easier.

I can do it manually for you if you want, but the commit log will
show me as committer that way.

Thanks,
Ben

Ben Greear greearb@candelatech.com
Candela Technologies Inc http://www.candelatech.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.