New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused field _eventloop in xrl_cli_node #112

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@hsn10
Contributor

hsn10 commented Dec 23, 2013

clang 3.3 do not likes this

hsn10 added some commits Dec 23, 2013

Revert parts of commit ddd8339.
remove only private field, keep argument event loop in constructor
@greearb

This comment has been minimized.

Show comment
Hide comment
@greearb

greearb Dec 23, 2013

Owner

Please merge these changes into a single patch, I do not want to merge needless reverts upstream.

Owner

greearb commented Dec 23, 2013

Please merge these changes into a single patch, I do not want to merge needless reverts upstream.

@hsn10

This comment has been minimized.

Show comment
Hide comment
@hsn10

hsn10 Dec 23, 2013

Contributor

i am leaving it as it is, there is about 15 changes to go, i do not have infinite time in hand.

Contributor

hsn10 commented Dec 23, 2013

i am leaving it as it is, there is about 15 changes to go, i do not have infinite time in hand.

@greearb

This comment has been minimized.

Show comment
Hide comment
@greearb

greearb Dec 23, 2013

Owner

On 12/23/2013 01:37 PM, Radim Kolar wrote:

i am leaving it as it is, there is about 15 changes to go, i do not have infinite time in hand.


Reply to this email directly or view it on GitHub #112 (comment).

Check out 'stg', it makes merging patches and editing commit messages
easier.

I can do it manually for you if you want, but the commit log will
show me as committer that way.

Thanks,
Ben

Ben Greear greearb@candelatech.com
Candela Technologies Inc http://www.candelatech.com

Owner

greearb commented Dec 23, 2013

On 12/23/2013 01:37 PM, Radim Kolar wrote:

i am leaving it as it is, there is about 15 changes to go, i do not have infinite time in hand.


Reply to this email directly or view it on GitHub #112 (comment).

Check out 'stg', it makes merging patches and editing commit messages
easier.

I can do it manually for you if you want, but the commit log will
show me as committer that way.

Thanks,
Ben

Ben Greear greearb@candelatech.com
Candela Technologies Inc http://www.candelatech.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment