Skip to content

Fix eslint-plugin with SonarQube 25 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix eslint-plugin with SonarQube 25 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ dependency-reduced-pom.xml

# Auto-generated files
coverage
dist
1 change: 1 addition & 0 deletions eslint-plugin/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ node_modules
# Auto-generated files
*-report.json
.nyc_output
dist/pack
2 changes: 1 addition & 1 deletion eslint-plugin/lib/sonar.js → eslint-plugin/dist/rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*/
"use strict";

const rules = require("./rule-list");
const rules = require("../lib/rule-list");

module.exports = {
rules: rules.map((rule) => ({
Expand Down
7 changes: 4 additions & 3 deletions eslint-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,16 @@
"author": "Green Code Initiative",
"main": "./lib/standalone.js",
"files": [
"lib"
"lib",
"./dist/rules.js"
],
"scripts": {
"clean": "rimraf dist",
"clean": "rimraf dist/pack",
"lint": "yarn lint:eslint-docs && yarn lint:js",
"lint:eslint-docs": "eslint-doc-generator --check",
"lint:js": "eslint .",
"lint:fix": "eslint . --fix",
"pack:sonar": "npm pkg set main=\"./lib/sonar.js\" && mkdirp dist/pack && yarn pack -o dist/pack/creedengo-eslint-plugin.tgz && npm pkg set main=\"./lib/standalone.js\"",
"pack:sonar": "npm pkg set main=\"./dist/rules.js\" && mkdirp dist/pack && yarn pack -o dist/pack/creedengo-eslint-plugin.tgz && npm pkg set main=\"./lib/standalone.js\"",
"test": "mocha tests --recursive",
"test:cov": "nyc --reporter=lcov --reporter=text mocha tests --recursive",
"update:eslint-docs": "eslint-doc-generator"
Expand Down
4 changes: 2 additions & 2 deletions eslint-plugin/tests/lib/sonar.test.js → eslint-plugin/tests/dist/rules.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@

const assert = require("assert");

describe("sonar.js", () => {
describe("rules.js", () => {
it("should export all rules with a specific rule id pattern", () => {
const { rules } = require("../../lib/sonar");
const { rules } = require("../../dist/rules");
assert.notEqual(rules.length, 0);
assert.match(rules[0].ruleId, /@creedengo\/.*/);
assert.equal(rules[0].ruleConfig.length, 0);
Expand Down
2 changes: 1 addition & 1 deletion sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
sonar.organization=green-code-initiative
sonar.projectKey=green-code-initiative_ecoCode-linter
sonar.projectName=creedengo - JavaScript language
sonar.sources=eslint-plugin/lib/,sonar-plugin/src/main/java/
sonar.sources=eslint-plugin/lib/,eslint-plugin/dist/rules.js,sonar-plugin/src/main/java/
sonar.tests=eslint-plugin/tests/,sonar-plugin/src/test/java/
sonar.javascript.lcov.reportPaths=eslint-plugin/coverage/lcov.info
sonar.java.binaries=sonar-plugin/target/
Expand Down
Loading