Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile updates not triggering #477

Closed
ArneTR opened this issue Sep 24, 2023 · 2 comments
Closed

Dockerfile updates not triggering #477

ArneTR opened this issue Sep 24, 2023 · 2 comments
Assignees

Comments

@ArneTR
Copy link
Member

ArneTR commented Sep 24, 2023

@dan-mm The Python version for 3.11 is a already 3.11.5 for about a month

However so far Dependabot has not triggered in this file: https://github.com/green-coding-berlin/green-metrics-tool/blob/main/docker/Dockerfile-gunicorn

Can you tell why?

@dan-mm
Copy link
Contributor

dan-mm commented Sep 25, 2023

Fixed in main now.

Our dependabot was not configured correctly. It was only looking for dockerfiles located in the root directory.

The main issue here is that dependabot does not search folders recursively:

dependabot/dependabot-core#2178
dependabot/dependabot-core#1015

This means that any new dockerfiles that we add which are not directly in the root of the docker subfolder will also need an update to the dependabot.yml file. this is relevant as we are planning on making and pushing docker containers automatically from the docker/auxiliary-containers folder :-/ Based on the issues posted above, I don't think there's a good solution to this at the moment.

But at least for now, I've updated our dependabot to find our current dockerfiles

@ArneTR
Copy link
Member Author

ArneTR commented Sep 26, 2023

can be closed? I have seen the Dependabot working now ...

@dan-mm dan-mm closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants